Fix #459: Upgrade protobuf to 3.7.0 to get rid of Java 9+ warnings #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea if this is binary-compatible so fingers crossed.
|
A validation involving this pull request is in progress... |
|
The validator has checked the following projects, tested using dbuild, projects built on top of each other.
❌ The result is: FAILED |
|
Looks like sbt doesn't compile with zinc master, so hard to test things more. |
|
I saw the drone job fail first, so I restarted it. Now it's green, so it's good to go, I think. |
eed3si9n
approved these changes
Mar 11, 2019
jvican
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea if this is binary-compatible so fingers crossed.