-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AuxiliaryClassFiles in IncOptions #956
Conversation
Could you exercise this from https://github.com/sbt/zinc/blob/develop/zinc/src/test/scala/sbt/inc/IncrementalCompilerSpec.scala or scripted test somehow? |
Thanks for working on this!
I wonder if besides .tasty we shouldn't also hardcode .sjsir and .nir by default, it shouldn't break anything and it means that mill/bloop/maven/... don't have to remember to do this themselves. /cc @sjrd |
internal/compiler-interface/src/main/java/xsbti/compile/AuxiliaryClassFiles.java
Outdated
Show resolved
Hide resolved
We could do that. I don't have a strong opinion either way. If Zinc doesn't do it by default, sbt-scalajs and sbt-scala-native will keep doing it. |
Add auxiliaryClassFiles member in IncOptions to manage files that are associated to class files. Provide an implementation for TASTy files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I have a few comments.
Fixes #579
Add an
AuxiliaryClassFiles
member inIncOptions
so that theClassFileManager
manages the files that are associated to class files. This will be used for Scala 3 (.tasty
files), for Scala.js (.sjsir
files) and for Scala Native (.nir
files).The
auxiliaryClassFiles
member inIncOptions
is an array so that we can manage several type of files at the same time (for instance.tasty
and.sjsir
files). Its default value is an empty array because Scala 2 and Java don't need any.The implementation for
.tasty
files is provided so that it can already be reused by sbt (sbt/sbt#6080) and also by Mill and Bloop.