Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Update plugin.json to match project readme #70

Merged
merged 1 commit into from
May 24, 2023

Conversation

sympatheticmoose
Copy link
Contributor

Hi there 👋

I noticed some oddities occurring where the latest version of your plugin wasn't being installed.

Given the statement in your readme:

Grafana version 7.3.x or above are supported

I believe this should be the setting for grafanaDependency

Setting at 7.3.x means it will only work on 7.3.x versions of Grafana.

Thanks for your contribution 🙌

@sbueringer
Copy link
Owner

Hey,
thx! Does it work with higher versions?
I haven't been actively maintaining this plugin for a while

@sympatheticmoose
Copy link
Contributor Author

I'll see if I've got a test env to hand... failing that, we've got an is-compatible GitHub action which could use to at least see if any Grafana incompatibilities are detected

@sympatheticmoose
Copy link
Contributor Author

sympatheticmoose commented May 24, 2023

@sbueringer so I ran a compatibility check and all seems fine 🎉

🔬 Checking compatibility between ./module.ts and @grafana/data@9.5.2...
✔ Found @grafana/data version 7.3.3 locally
✔ Installed @grafana/data@7.3.3 successfully
✔ Installed @grafana/data@9.5.2 successfully
✔ Successfully compared versions

✔️  ./module.ts appears to be compatible with @grafana/data@latest
---
🔬 Checking compatibility between ./module.ts and @grafana/ui@9.5.2...
✔ Found @grafana/ui version 7.3.3 locally
✔ Installed @grafana/ui@7.3.3 successfully
✔ Installed @grafana/ui@9.5.2 successfully
✔ Successfully compared versions

✔️  ./module.ts appears to be compatible with @grafana/ui@latest
---
🔬 Checking compatibility between ./module.ts and @grafana/runtime@9.5.2...
✔ Found @grafana/runtime version 7.3.3 locally
✔ Installed @grafana/runtime@7.3.3 successfully
✔ Installed @grafana/runtime@9.5.2 successfully
✔ Successfully compared versions

✔️  ./module.ts appears to be compatible with @grafana/runtime@latest
---
🔬 Checking compatibility between ./module.ts and @grafana/schema@9.5.2...
   Skipping package @grafana/schema because it is not used in the project or not installed locally.
   did you forget to run yarn install or npm install?

✔️  ./module.ts appears to be compatible with @grafana/schema@latest
---
🔬 Checking compatibility between ./module.ts and @grafana/e2e-selectors@9.5.2...
   Skipping package @grafana/e2e-selectors because it is not used in the project or not installed locally.
   did you forget to run yarn install or npm install?

✔️  ./module.ts appears to be compatible with @grafana/e2e-selectors@latest

Also stuck the current version through the validator:

error: The version in package.json (1.0.0) doesn't match the version in plugin.json (0.2.1)
detail: The version in the source code package.json must match the version in plugin.json
error: LICENSE file not found
detail: Could not find a license file inside the plugin archive. Please make sure to include a LICENSE file in your archive.
warning: plugin.json: grafanaDependency only targets patch releases of Grafana 7.3
detail: The plugin will only work in patch releases of the specified minor Grafana version.
error: Plugin version 0.2.1 is invalid.
detail: The submitted plugin version 0.2.1 is not greater than the latest published version 0.2.1 on grafana.com.

So there would just be a couple of simple metadata issues to clear up (one of which is solved through this PR)

@sbueringer
Copy link
Owner

Alright, thank you very much!

@sbueringer sbueringer merged commit e1a04c5 into sbueringer:master May 24, 2023
@sympatheticmoose
Copy link
Contributor Author

@sbueringer Hey - just wondered the latest on this and whether you would be interested in publishing a new version to resolve this issue?

I haven't been actively maintaining this plugin for a while

Alternatively, given this - if you would prefer we could deprecate the plugin so that it is no longer available for new users in the catalog (existing users would not be impacted)

@sbueringer
Copy link
Owner

I'll try to publish a release soon

@sbueringer
Copy link
Owner

@sympatheticmoose Thx for the ping :). Published the release and did some verification. As far as I can tell it should work

@sbueringer
Copy link
Owner

@sympatheticmoose Sorry it has been years since I did this the last time. What has to happen to make the new version available here https://grafana.com/grafana/plugins/sbueringer-consul-datasource/?

@sympatheticmoose
Copy link
Contributor Author

Hey @sbueringer no problem - I can help point you in the right direction. These docs will guide you through the process https://grafana.com/docs/grafana/latest/developers/plugins/publish-a-plugin/

However... I was just checking out a few things and theres likely some more stuff which would get flagged in review. https://github.com/sbueringer/grafana-consul-datasource/blob/v0.2.2/go.mod has the module name of one of our samples and is showing that things are quite far out of date like the go version and our SDK... It also looks like the project was using Toolkit which is no longer supported, so would be best to migrate https://grafana.github.io/plugin-tools/docs/getting-started/migrating-from-toolkit

@sbueringer
Copy link
Owner

Thx for taking a closer look. I think then let's deprecate the plugin. Realistically I won't have the time to bring this plugin to the latest state of the art.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants