-
Notifications
You must be signed in to change notification settings - Fork 7
Update plugin.json to match project readme #70
Conversation
Hey, |
I'll see if I've got a test env to hand... failing that, we've got an is-compatible GitHub action which could use to at least see if any Grafana incompatibilities are detected |
@sbueringer so I ran a compatibility check and all seems fine 🎉
Also stuck the current version through the validator:
So there would just be a couple of simple metadata issues to clear up (one of which is solved through this PR) |
Alright, thank you very much! |
@sbueringer Hey - just wondered the latest on this and whether you would be interested in publishing a new version to resolve this issue?
Alternatively, given this - if you would prefer we could deprecate the plugin so that it is no longer available for new users in the catalog (existing users would not be impacted) |
I'll try to publish a release soon |
@sympatheticmoose Thx for the ping :). Published the release and did some verification. As far as I can tell it should work |
@sympatheticmoose Sorry it has been years since I did this the last time. What has to happen to make the new version available here https://grafana.com/grafana/plugins/sbueringer-consul-datasource/? |
Hey @sbueringer no problem - I can help point you in the right direction. These docs will guide you through the process https://grafana.com/docs/grafana/latest/developers/plugins/publish-a-plugin/ However... I was just checking out a few things and theres likely some more stuff which would get flagged in review. https://github.com/sbueringer/grafana-consul-datasource/blob/v0.2.2/go.mod has the module name of one of our samples and is showing that things are quite far out of date like the go version and our SDK... It also looks like the project was using Toolkit which is no longer supported, so would be best to migrate https://grafana.github.io/plugin-tools/docs/getting-started/migrating-from-toolkit |
Thx for taking a closer look. I think then let's deprecate the plugin. Realistically I won't have the time to bring this plugin to the latest state of the art. |
Hi there 👋
I noticed some oddities occurring where the latest version of your plugin wasn't being installed.
Given the statement in your readme:
I believe this should be the setting for
grafanaDependency
Setting at
7.3.x
means it will only work on 7.3.x versions of Grafana.Thanks for your contribution 🙌