Skip to content

Commit

Permalink
Lint internal scripts with eslint:recommended (facebook#1729)
Browse files Browse the repository at this point in the history
* Lint internal scripts with eslint:recommended

* Warnings r bad
  • Loading branch information
gaearon authored Mar 5, 2017
1 parent add3cd7 commit b74878d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions bin/react-scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ case 'test':
{stdio: 'inherit'}
);
if (result.signal) {
if (result.signal == 'SIGKILL') {
if (result.signal === 'SIGKILL') {
console.log(
'The build failed because the process exited too early. ' +
'This probably means the system ran out of memory or someone called ' +
'`kill -9` on the process.'
);
} else if (result.signal == 'SIGTERM') {
} else if (result.signal === 'SIGTERM') {
console.log(
'The build failed because the process exited too early. ' +
'Someone might have called `kill` or `killall`, or the system could ' +
Expand Down
2 changes: 1 addition & 1 deletion fixtures/kitchensink/integration/initDOM.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ if (process.env.E2E_FILE) {
const markup = fs.readFileSync(file, 'utf8')
getMarkup = () => markup

const pathPrefix = process.env.PUBLIC_URL.replace(/^https?:\/\/[^\/]+\/?/, '')
const pathPrefix = process.env.PUBLIC_URL.replace(/^https?:\/\/[^/]+\/?/, '')

resourceLoader = (resource, callback) => callback(
null,
Expand Down

0 comments on commit b74878d

Please sign in to comment.