Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command option to specify the source files to run the coverage on #806

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add command option to specify the source files to run the coverage on #806

merged 1 commit into from
Feb 2, 2024

Conversation

clauBv23
Copy link
Contributor

solves #805

The solution proposed is to add a --sources command option to specify the file source.

@cgewecke cgewecke self-requested a review February 2, 2024 03:10
@cgewecke cgewecke changed the base branch from master to staging/sources-flag February 2, 2024 03:11
cgewecke
cgewecke approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR and apologies for the very late review.

I'm going to merge this into a local staging branch to take a closer look and make a couple small changes (since it's been so long since you opened this).

@cgewecke cgewecke merged commit f91532e into sc-forks:staging/sources-flag Feb 2, 2024
@cgewecke cgewecke mentioned this pull request Feb 2, 2024
Merged
cgewecke added a commit that referenced this pull request Feb 2, 2024
@cgewecke @clauBv23
Add command option to specify the source files to run the coverage on (…
3f767d7 
…#806) (#838)

Co-authored-by: Claudia Barcelo <claudiabarcelovaldes40@gmail.com>
@clauBv23 clauBv23 deleted the add-sources-command-option branch February 2, 2024 09:15
This was referenced Jun 15, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Jul 13, 2024
Closed
This was referenced Jul 17, 2024
Open
Open
@tobistudio tobistudio mentioned this pull request Jul 23, 2024
Closed
@nek0ill nek0ill mentioned this pull request Jul 27, 2024
Open
@tobistudio tobistudio mentioned this pull request Jul 31, 2024
Closed
@nek0ill nek0ill mentioned this pull request Jul 31, 2024
Open
This was referenced Aug 2, 2024
Closed
Closed
This was referenced Aug 6, 2024
Open
Open
@tobistudio tobistudio mentioned this pull request Aug 8, 2024
Closed
@nek0ill nek0ill mentioned this pull request Aug 9, 2024
Open
This was referenced Aug 16, 2024
Closed
Closed
@nek0ill nek0ill mentioned this pull request Aug 22, 2024
Open
@tobistudio tobistudio mentioned this pull request Aug 24, 2024
Closed
@nek0ill nek0ill mentioned this pull request Aug 30, 2024
Open
@tobistudio tobistudio mentioned this pull request Aug 31, 2024
Closed
This was referenced Sep 1, 2024
Closed
Closed
@nek0ill nek0ill mentioned this pull request Sep 3, 2024
Open
@tobistudio tobistudio mentioned this pull request Sep 4, 2024
Closed
@nek0ill nek0ill mentioned this pull request Sep 4, 2024
Open
@tobistudio tobistudio mentioned this pull request Sep 6, 2024
Closed
@nek0ill nek0ill mentioned this pull request Sep 7, 2024
Open
@tobistudio tobistudio mentioned this pull request Sep 10, 2024
Closed
@nek0ill nek0ill mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 19, 2024
Open
Open
Open
This was referenced Sep 24, 2024
Closed
Closed
@nek0ill nek0ill mentioned this pull request Sep 25, 2024
Open
@tobistudio tobistudio mentioned this pull request Sep 26, 2024
Closed
@nek0ill nek0ill mentioned this pull request Sep 26, 2024
Open
@tobistudio tobistudio mentioned this pull request Sep 27, 2024
Closed
@nek0ill nek0ill mentioned this pull request Sep 29, 2024
Open
@tobistudio tobistudio mentioned this pull request Sep 30, 2024
Closed
@nek0ill nek0ill mentioned this pull request Oct 2, 2024
Open
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 3, 2024
Open
@nek0ill nek0ill mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clauBv23 @cgewecke