Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Istanbul check-coverage cli command #834

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Jan 27, 2024

#610

NB: update this for v0.9.x when nyc is put in (#825)

@@ -138,6 +138,19 @@ There's a nice example of this being done in CircleCI [at Synthetix, here][31].

:bulb: **Pro Tip**: Codecov CI will automatically combine coverage reports sent to them as a batch - if you're using that service you don't need to do this yourself.

## Coverage threshold checks

Istanbul has a command line utility which can be used to set thresholds for different coverage categories and throw an error if your coverage drops below them. (Istanbul is a solidity-coverage dependency so you shouldn't need to install it separately.)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgewecke cgewecke merged commit 54bfdbd into master Jan 27, 2024
2 of 3 checks passed
@cgewecke cgewecke deleted the add-threshold-docs branch January 27, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant