-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error if --solcoverjs passed but file is nonexistent #889
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
=======================================
Coverage 96.62% 96.63%
=======================================
Files 19 19
Lines 1066 1069 +3
=======================================
+ Hits 1030 1033 +3
Misses 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! 👋
Thanks for this, definitely how it should be :)
It's been a while 😅 - hope things are good on your side.
While reworking my test suite, I lost a lot of time to this peculiarity and a hard-to-spot typo on my side, so thought I'd see if there was an appetite to saving other people the bother down the line. I realise this is a breaking change though; would be happy to turn it in to a warning rather than an outright failure, if that's a concern.