Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow root level command naming convention #164

Conversation

schmidsi
Copy link

@schmidsi schmidsi commented Dec 4, 2024

@technophile-04
Copy link
Collaborator

but I don't understand how this back-merging thing works as described here: https://github.com/scaffold-eth/create-eth/blob/main/contributors/DEVELOPER-GUIDE.md#back-merging-main-branch--publishing-to-npm

Ohh actually since this repo (create-eth) is a fork of Scaffold-ETH 2 repo. Any changes to SE-2 files we first merge the PR in SE-2 repo and backmerge those changes in this create-eth repo. Since this a fork and has all the commit history, git most of the time automatically is able to detect the changes nicely and merge them.

So closing this for now, when we make backmerge PR like #149 this changes will be already include 🙌

@schmidsi
Copy link
Author

schmidsi commented Dec 5, 2024

Ah, ok. I wondered how this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants