Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use caret for burner-connector versioning #17

Merged
merged 4 commits into from
May 1, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented May 1, 2024

Description

For some wired reason, when if we use ~ for burner-connector it give me "module not found error"

Screenshot 2024-05-01 at 2 25 07 PM

, using ^ does seem to solve that problem

@rin-st
Copy link
Member

rin-st commented May 1, 2024

Strange, ~ doesn't work for me too.

Noticed that on gh last burner-connector release on the repo is 0.0.3, but on npm is 0.04. How does this work? Also I think it should have a version on package json.

Create-eth also has a version mismatch (0.0.39 gh vs 0.0.35 npm), but it's another story

@technophile-04
Copy link
Collaborator Author

Noticed that on gh last burner-connector release on the repo is 0.0.3, but on npm is 0.04. How does this work?

Ohh actually gh is not showing 0.0.4 tags release because, yesterday instead of creating PR and publishing version with github bot we published the version directly through CLI.

@carletex could you please run git push --follow-tags on burnerConnector repo, I think this will publish the tags to github repo too as mentioned here, I think we forgot to do this step yesterday my bad.

Also I think it should have a version on package json.

Ohh yeah we do have a version in pacakge.json here, maybe you were looking at root of monorepo ?

Create-eth also has a version mismatch (0.0.39 gh vs 0.0.35 npm), but it's another story

Strange, for me both are at same version

GH npm
Screenshot 2024-05-01 at 6 35 59 PM Screenshot 2024-05-01 at 6 35 04 PM

Merging this, just tested it out. Thanks all !!

@technophile-04 technophile-04 merged commit 8596b36 into main May 1, 2024
@technophile-04 technophile-04 deleted the fix/burner-connector-version branch May 1, 2024 13:09
@rin-st
Copy link
Member

rin-st commented May 1, 2024

Ohh yeah we do have a version in pacakge.json here, maybe you were looking at root of monorepo ?

Got it, thanks!

Strange, for me both are at same version

Sorry, for some reason it was a version inside URL 😄
image

@carletex
Copy link
Member

carletex commented May 1, 2024

@carletex could you please run git push --follow-tags on burnerConnector repo, I think this will publish the tags to github repo too as mentioned here, I think we forgot to do this step yesterday my bad.

Just did! @technophile-04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants