-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt readme and contributing guide to create-eth repo #26
Conversation
Lgtm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @Pabl0cks Thank you!
left a comment in case you guys see it interesting to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm @Pabl0cks, looking great !
One thing I would like to mention maybe not in this PR and maybe after #25 is after point 1. in qucikstart after foundry hint maybe we could mention that checkout generated README for more details on getting started / commands (maybe we could also mention this at end)
^ But yeah lol it might be not needed since after #25 we will be already mentioning this at the end in CLI output 🙌
Yep, nice idea! 🙌 Not sure where the best place would be. What about in
Not so sure about the location, just thinking out loud! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great starting point!
Thank you all!
Initial tweaks to adapt old SE-2 Readme and Contributing guide to new create-eth repo.
Maybe I deleted too much stuff in Readme for a initial iteration, we can get back basic SE-2 screenshot and features from initial part of the Readme if you prefer 🙌
Fixes #10