Untracked changes foundry

[technophile-04]

Description :

When you do :

npx create-eth@latest 

and choose foundry, you get untracked changes:

Lol spend alot of time debugging this and this was best / minimal I could come up with.

I am completely not sure why this happening, but main reason seems OZ master branch and latest tag released divert a bit. Checkout master vs v5 release and some removing / adding of files from v4 => v5 which are not properly reflected in gitsubmodules.

There might some better approaches, but wasn't able to find any good working solution.

One better solution will be to use forge install instead of manually running git submodule but we are assuming that when people use CLI they be some case when forge is not installed and hence we show them

create-eth/src/utils/render-outro-message.ts

Line 26 in 764d5c2

\t${chalk.bold.yellow("(NOTE: Foundryup is not installed in your system)")}

[rin-st]

Lol spend alot of time debugging this and this was best / minimal I could come up with.

Same 😄

I am completely not sure why this happening, but main reason seems OZ master branch and latest tag released divert a bit. Checkout master vs v5 release and some removing / adding of files from v4 => v5 which are not properly reflected in gitsubmodules.

I think you already seen this https://github.com/OpenZeppelin/openzeppelin-contracts?tab=readme-ov-file#foundry-git . For some reason when initial commit is created

    await execa("git", ["add", "-A"], { cwd: targetDir });
    await execa("git", ["commit", "-m", "Initial commit with 🏗️ Scaffold-ETH 2", "--no-verify"], { cwd: targetDir });

last tag doesn't work and it always points to master. When we're doing

if (options.extensions?.includes("foundry")) {
      await execa("git", ["submodule", "update", "--init", "--recursive"], {
        cwd: path.resolve(targetDir, "packages", "foundry"),
      });
    }

it updates to last tag, and hence it can differ from master.

---

I tried to add another commit at the end (doesn't work since it don't see changed files) or do --ammend (still points to master) and other things but didn't find something adequate

So I think your solution is good, until they bump it to v6 :)

Gj!

[technophile-04]

Tysm @rin-st for tinkering !!

So I think your solution is good, until they bump it to v6 :)

Ohh yes not the best, but merging this as hotfix since v6 is far but yeah def let's try to find a better / more generic solution 🙌