don't prompt for install + remove prettier plugins #80

technophile-04 · 2024-07-12T08:09:37Z

Description:

Removed prompt for installing dependencies
- --skip-install is an escape hatch (not completely sure if we should remove or keep it but sometimes its pretty handy)
Removed prettiers plugins which were installed due to prettier format instance with cli itself #55 + moved prettier to devDependency

rin-st · 2024-07-12T13:55:17Z

--skip + cd + install works well.

But with default install I'm getting this

Details

yarn cli

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| Create Scaffold-ETH 2 app |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

? Your project name: ffd
? What solidity framework do you want to use? hardhat

✔ 📁 Create project directory /Users/liana/Documents/prog/buidl-guidl/create-eth/ffd
✔ 🚀 Creating a new Scaffold-ETH 2 app in ffd
✖ Command failed: yarn install
➤ YN0000: ┌ Resolution step
➤ YN0061: │ glob@npm:7.1.7 is deprecated: Glob versions prior to v9 are no longer
supported
➤ YN0061: │ glob@npm:7.2.0 is deprecated: Glob versions prior to v9 are no longer
supported
➤ YN0061: │ glob@npm:7.2.3 is deprecated: Glob versions prior to v9 are no longer
supported
➤ YN0061: │ glob@npm:5.0.15 is deprecated: Glob versions prior to v9 are no longer
supported
➤ YN0061: │ glob@npm:8.1.0 is deprecated: Glob versions prior to v9 are no longer
supported
➤ YN0032: │ keccak@npm:3.0.4: Implicit dependencies on node-gyp are discouraged
➤ YN0061: │ inflight@npm:1.0.6 is deprecated: This module is not supported, and leaks
memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce
async requests by a key value, which is much more comprehensive and powerful.
➤ YN0061: │ @humanwhocodes/config-array@npm:0.11.14 is deprecated: Use
@eslint/config-array instead
➤ YN0061: │ @humanwhocodes/config-array@npm:0.10.7 is deprecated: Use
@eslint/config-array instead
➤ YN0061: │ zksync-web3@npm:0.14.4 is deprecated: This package has been deprecated in
favor of zksync-ethers@5.0.0
➤ YN0061: │ debug@npm:4.1.1 is deprecated: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1
have a low-severity ReDos regression when used in a Node.js environment. It is
recommended you upgrade to 3.2.7 or 4.3.1.
(debug-js/debug#797)
➤ YN0061: │ uuid@npm:3.3.2 is deprecated: Please upgrade to version 7 or higher. Older
versions may use Math.random() in certain circumstances, which is known to be
problematic. See https://v8.dev/blog/math-random for details.
➤ YN0032: │ fsevents@npm:2.3.3: Implicit dependencies on node-gyp are discouraged
➤ YN0032: │ fsevents@npm:2.1.3: Implicit dependencies on node-gyp are discouraged
➤ YN0061: │ fsevents@npm:2.1.3 is deprecated: "Please update to latest v2.3 or v2.2"
➤ YN0032: │ node-addon-api@npm:2.0.2: Implicit dependencies on node-gyp are discouraged
➤ YN0061: │ rimraf@npm:2.7.1 is deprecated: Rimraf versions prior to v4 are no longer
supported
➤ YN0061: │ rimraf@npm:3.0.2 is deprecated: Rimraf versions prior to v4 are no longer
supported
➤ YN0032: │ secp256k1@npm:4.0.3: Implicit dependencies on node-gyp are discouraged
➤ YN0001: │ Error: a@npm:~1.2.3: No candidates found
at ce (/Users/liana/Documents/prog/buidl-guidl/create-eth/ffd/.yarn/releases/yarn-3.2.3.c
js:439:7864)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Promise.allSettled (index 11)
at async ho (/Users/liana/Documents/prog/buidl-guidl/create-eth/ffd/.yarn/releases/yarn-3
.2.3.cjs:390:10446)
➤ YN0000: └ Completed in 5s 595ms
➤ YN0000: Failed with errors in 5s 598ms
➤ YN0061: @humanwhocodes/object-schema@npm:2.0.3 is deprecated: Use @eslint/object-schema
instead
➤ YN0061: @humanwhocodes/object-schema@npm:1.2.1 is deprecated: Use @eslint/object-schema
instead
➤ YN0032: evp_bytestokey@npm:1.0.3: Implicit dependencies on node-gyp are discouraged
➤ YN0032: classic-level@npm:1.4.1: Implicit dependencies on node-gyp are discouraged
➤ YN0032: secp256k1@npm:5.0.0: Implicit dependencies on node-gyp are discouraged
➤ YN0032: node-addon-api@npm:5.1.0: Implicit dependencies on node-gyp are discouraged
➤ YN0061: npmlog@npm:5.0.1 is deprecated: This package is no longer supported.
➤ YN0032: bufferutil@npm:4.0.8: Implicit dependencies on node-gyp are discouraged
➤ YN0032: utf-8-validate@npm:6.0.4: Implicit dependencies on node-gyp are discouraged
➤ YN0061: are-we-there-yet@npm:2.0.0 is deprecated: This package is no longer supported.
➤ YN0061: gauge@npm:3.0.2 is deprecated: This package is no longer supported.
➤ YN0061: @motionone/vue@npm:10.16.4 is deprecated: Motion One for Vue is deprecated. Use
Oku Motion instead https://oku-ui.com/motion
➤ YN0032: @parcel/watcher@npm:2.4.1: Implicit dependencies on node-gyp are discouraged
➤ YN0032: node-addon-api@npm:7.1.1: Implicit dependencies on node-gyp are discouraged
◼ 🪄 Formatting files
◼ 📡 Initializing Git repository
ERROR Error occurred Error: Command failed: yarn install
➤ YN0000: ┌ Resolution step
➤ YN0061: │ glob@npm:7.1.7 is deprecated: Glob versions prior to v9 are no longer supported
➤ YN0061: │ glob@npm:7.2.0 is deprecated: Glob versions prior to v9 are no longer supported
➤ YN0061: │ glob@npm:7.2.3 is deprecated: Glob versions prior to v9 are no longer supported
➤ YN0061: │ glob@npm:5.0.15 is deprecated: Glob versions prior to v9 are no longer supported
➤ YN0061: │ glob@npm:8.1.0 is deprecated: Glob versions prior to v9 are no longer supported
➤ YN0032: │ keccak@npm:3.0.4: Implicit dependencies on node-gyp are discouraged
➤ YN0061: │ inflight@npm:1.0.6 is deprecated: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
➤ YN0061: │ @humanwhocodes/config-array@npm:0.11.14 is deprecated: Use @eslint/config-array instead
➤ YN0061: │ @humanwhocodes/config-array@npm:0.10.7 is deprecated: Use @eslint/config-array instead
➤ YN0061: │ zksync-web3@npm:0.14.4 is deprecated: This package has been deprecated in favor of zksync-ethers@5.0.0
➤ YN0061: │ debug@npm:4.1.1 is deprecated: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (debug-js/debug#797)
➤ YN0061: │ uuid@npm:3.3.2 is deprecated: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
➤ YN0032: │ fsevents@npm:2.3.3: Implicit dependencies on node-gyp are discouraged
➤ YN0032: │ fsevents@npm:2.1.3: Implicit dependencies on node-gyp are discouraged
➤ YN0061: │ fsevents@npm:2.1.3 is deprecated: "Please update to latest v2.3 or v2.2"
➤ YN0032: │ node-addon-api@npm:2.0.2: Implicit dependencies on node-gyp are discouraged
➤ YN0061: │ rimraf@npm:2.7.1 is deprecated: Rimraf versions prior to v4 are no longer supported
➤ YN0061: │ rimraf@npm:3.0.2 is deprecated: Rimraf versions prior to v4 are no longer supported
➤ YN0032: │ secp256k1@npm:4.0.3: Implicit dependencies on node-gyp are discouraged
➤ YN0001: │ Error: a@npm:~1.2.3: No candidates found
at ce (/Users/liana/Documents/prog/buidl-guidl/create-eth/ffd/.yarn/releases/yarn-3.2.3.cjs:439:7864)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Promise.allSettled (index 11)
at async ho (/Users/liana/Documents/prog/buidl-guidl/create-eth/ffd/.yarn/releases/yarn-3.2.3.cjs:390:10446)
➤ YN0000: └ Completed in 5s 595ms
➤ YN0000: Failed with errors in 5s 598ms
➤ YN0061: @humanwhocodes/object-schema@npm:2.0.3 is deprecated: Use @eslint/object-schema instead
➤ YN0061: @humanwhocodes/object-schema@npm:1.2.1 is deprecated: Use @eslint/object-schema instead
➤ YN0032: evp_bytestokey@npm:1.0.3: Implicit dependencies on node-gyp are discouraged
➤ YN0032: classic-level@npm:1.4.1: Implicit dependencies on node-gyp are discouraged
➤ YN0032: secp256k1@npm:5.0.0: Implicit dependencies on node-gyp are discouraged
➤ YN0032: node-addon-api@npm:5.1.0: Implicit dependencies on node-gyp are discouraged
➤ YN0061: npmlog@npm:5.0.1 is deprecated: This package is no longer supported.
➤ YN0032: bufferutil@npm:4.0.8: Implicit dependencies on node-gyp are discouraged
➤ YN0032: utf-8-validate@npm:6.0.4: Implicit dependencies on node-gyp are discouraged
➤ YN0061: are-we-there-yet@npm:2.0.0 is deprecated: This package is no longer supported.
➤ YN0061: gauge@npm:3.0.2 is deprecated: This package is no longer supported.
➤ YN0061: @motionone/vue@npm:10.16.4 is deprecated: Motion One for Vue is deprecated. Use Oku Motion instead https://oku-ui.com/motion
➤ YN0032: @parcel/watcher@npm:2.4.1: Implicit dependencies on node-gyp are discouraged
➤ YN0032: node-addon-api@npm:7.1.1: Implicit dependencies on node-gyp are discouraged

at makeError (/Users/liana/Documents/prog/buidl-guidl/create-eth/node_modules/pkg-install/node_modules/execa/index.js:174:9)
at /Users/liana/Documents/prog/buidl-guidl/create-eth/node_modules/pkg-install/node_modules/execa/index.js:278:16
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Task.run (file:///Users/liana/Documents/prog/buidl-guidl/create-eth/node_modules/listr2/dist/index.js:2056:11) {

code: 1,
stdout: '➤ YN0000: ┌ Resolution step\n' +
'➤ YN0061: │ glob@npm:7.1.7 is deprecated: Glob versions prior to v9 are no longer supported\n' +
'➤ YN0061: │ glob@npm:7.2.0 is deprecated: Glob versions prior to v9 are no longer supported\n' +
'➤ YN0061: │ glob@npm:7.2.3 is deprecated: Glob versions prior to v9 are no longer supported\n' +
'➤ YN0061: │ glob@npm:5.0.15 is deprecated: Glob versions prior to v9 are no longer supported\n' +
'➤ YN0061: │ glob@npm:8.1.0 is deprecated: Glob versions prior to v9 are no longer supported\n' +
'➤ YN0032: │ keccak@npm:3.0.4: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0061: │ inflight@npm:1.0.6 is deprecated: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.\n' +
'➤ YN0061: │ @humanwhocodes/config-array@npm:0.11.14 is deprecated: Use @eslint/config-array instead\n' +
'➤ YN0061: │ @humanwhocodes/config-array@npm:0.10.7 is deprecated: Use @eslint/config-array instead\n' +
'➤ YN0061: │ zksync-web3@npm:0.14.4 is deprecated: This package has been deprecated in favor of zksync-ethers@5.0.0\n' +
'➤ YN0061: │ debug@npm:4.1.1 is deprecated: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)\n' +
'➤ YN0061: │ uuid@npm:3.3.2 is deprecated: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.\n' +
'➤ YN0032: │ fsevents@npm:2.3.3: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0032: │ fsevents@npm:2.1.3: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0061: │ fsevents@npm:2.1.3 is deprecated: "Please update to latest v2.3 or v2.2"\n' +
'➤ YN0032: │ node-addon-api@npm:2.0.2: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0061: │ rimraf@npm:2.7.1 is deprecated: Rimraf versions prior to v4 are no longer supported\n' +
'➤ YN0061: │ rimraf@npm:3.0.2 is deprecated: Rimraf versions prior to v4 are no longer supported\n' +
'➤ YN0032: │ secp256k1@npm:4.0.3: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0001: │ Error: a@npm:~1.2.3: No candidates found\n' +
' at ce (/Users/liana/Documents/prog/buidl-guidl/create-eth/ffd/.yarn/releases/yarn-3.2.3.cjs:439:7864)\n' +
' at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n' +
' at async Promise.allSettled (index 11)\n' +
' at async ho (/Users/liana/Documents/prog/buidl-guidl/create-eth/ffd/.yarn/releases/yarn-3.2.3.cjs:390:10446)\n' +
'➤ YN0000: └ Completed in 5s 595ms\n' +
'➤ YN0000: Failed with errors in 5s 598ms\n' +
'➤ YN0061: @humanwhocodes/object-schema@npm:2.0.3 is deprecated: Use @eslint/object-schema instead\n' +
'➤ YN0061: @humanwhocodes/object-schema@npm:1.2.1 is deprecated: Use @eslint/object-schema instead\n' +
'➤ YN0032: evp_bytestokey@npm:1.0.3: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0032: classic-level@npm:1.4.1: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0032: secp256k1@npm:5.0.0: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0032: node-addon-api@npm:5.1.0: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0061: npmlog@npm:5.0.1 is deprecated: This package is no longer supported.\n' +
'➤ YN0032: bufferutil@npm:4.0.8: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0032: utf-8-validate@npm:6.0.4: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0061: are-we-there-yet@npm:2.0.0 is deprecated: This package is no longer supported.\n' +
'➤ YN0061: gauge@npm:3.0.2 is deprecated: This package is no longer supported.\n' +
'➤ YN0061: @motionone/vue@npm:10.16.4 is deprecated: Motion One for Vue is deprecated. Use Oku Motion instead https://oku-ui.com/motion\n' +
'➤ YN0032: @parcel/watcher@npm:2.4.1: Implicit dependencies on node-gyp are discouraged\n' +
'➤ YN0032: node-addon-api@npm:7.1.1: Implicit dependencies on node-gyp are discouraged\n',
stderr: '',
failed: true,
signal: null,
cmd: 'yarn install',
timedOut: false,
killed: false
}
Uh oh! 😕 Sorry about that! Exiting...

technophile-04 · 2024-07-15T06:19:39Z

Ohh strange, I just tried it with same options chosen / dir name and it seems to work for me :

My ClI Log :

yarn cli

 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 | Create Scaffold-ETH 2 app |
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+

? Your project name: ffd
? What solidity framework do you want to use? hardhat


✔ 📁 Create project directory /Users/shivbhonde/Desktop/Github/create-eth/ffd
✔ 🚀 Creating a new Scaffold-ETH 2 app in ffd
✔ 📦 Installing dependencies with yarn, this could take a while
✔ 🪄 Formatting files
✔ 📡 Initializing Git repository



  Congratulations! Your project has been scaffolded! 🎉

  Next steps:

  cd ffd

        Start the local development node
        yarn chain

        In a new terminal window, deploy your contracts
        yarn deploy

        In a new terminal window, start the frontend
        yarn start

  Thanks for using Scaffold-ETH 2 🙏, Happy Building!

Could you maybe try once :

npx create-eth@latest --install

Just to make sure its its not an problem with installing dependencies?

rin-st

My bad, I had test data from previous pr's 🤦

Good job, works well!

carletex · 2024-07-15T10:15:58Z

Works great @technophile-04

Good stuff!!

carletex · 2024-07-15T10:16:54Z

BTW, should have we added a changeset here?

technophile-04 · 2024-07-15T11:34:42Z

BTW, should have we added a changeset here?

Ohh yess! forgot about it :(, also btw could configure https://github.com/apps/changeset-bot in this repo which reminds to add changeset if necessary

carletex · 2024-07-15T14:44:21Z

That bot is nice too.

In any case, we need some kind of tweak in our workflow (release branches or auto-tag commits with versions or force changeset on PRs...) because if not it's hard to lose track code and the published npm version.

technophile-04 added 2 commits July 12, 2024 16:12

don't ask for install option

6f69aa1

remove prettier plugins + move prettier under devDepencies

193fa1c

technophile-04 requested review from carletex and rin-st July 12, 2024 10:51

rin-st approved these changes Jul 15, 2024

View reviewed changes

carletex merged commit 697fda9 into main Jul 15, 2024
1 check passed

carletex deleted the make-install-default branch July 15, 2024 10:16

technophile-04 mentioned this pull request Jul 17, 2024

formatting instance #77

Closed

technophile-04 added a commit that referenced this pull request Jul 17, 2024

add #80 changeset

094221c

github-actions bot mentioned this pull request Jul 17, 2024

Version Packages #83

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't prompt for install + remove prettier plugins #80

don't prompt for install + remove prettier plugins #80

technophile-04 commented Jul 12, 2024

rin-st commented Jul 12, 2024

technophile-04 commented Jul 15, 2024 •

edited

Loading

rin-st left a comment

carletex commented Jul 15, 2024

carletex commented Jul 15, 2024

technophile-04 commented Jul 15, 2024

carletex commented Jul 15, 2024

don't prompt for install + remove prettier plugins #80

don't prompt for install + remove prettier plugins #80

Conversation

technophile-04 commented Jul 12, 2024

Description:

rin-st commented Jul 12, 2024

technophile-04 commented Jul 15, 2024 • edited Loading

rin-st left a comment

Choose a reason for hiding this comment

carletex commented Jul 15, 2024

carletex commented Jul 15, 2024

technophile-04 commented Jul 15, 2024

carletex commented Jul 15, 2024

technophile-04 commented Jul 15, 2024 •

edited

Loading