Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)move Example UI #576

Closed
carletex opened this issue Oct 16, 2023 · 2 comments · Fixed by #578
Closed

(Re)move Example UI #576

carletex opened this issue Oct 16, 2023 · 2 comments · Fixed by #578

Comments

@carletex
Copy link
Member

Following feedback from some people and for the sake of keeping the codebase lighter, let's discuss what we can do with Example UI.

The idea behind it was to show beginners how to use SE2 (components, hooks, styling, etc), but I don't think it has been very useful for that purpose. Also, types break the moment you start tweaking the contract, and it's something you have to remove when deploying.

I see a couple of options:

  1. Remove it completely and create a good Recipes section in the SE-2 docs, where people can copy-paste examples that work out of the box. This is what most libraries/starter kits do. I already created the issue: Recipes se-2-docs#25, since the "Recipes" section is something that we wanted to do anyway.
  2. Add it in as an extension for the CLI. People could opt in if they want. "Would you like an example UI that shows how to style and use hooks?"

My vote is 1, since I don't like cluttering the CLI options with this, something that I feel it's not that important / useful.

Let's hear what you all think!

@damianmarti
Copy link
Member

Option 1 sounds good to me too!

@technophile-04
Copy link
Collaborator

Also, types break the moment you start tweaking the contract, and it's something you have to remove when deploying.

Ohh yeah that's another problem :(

Yup even I like 1st option 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants