Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExampleUI (pages, components, assets, content) #578

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Remove ExampleUI (pages, components, assets, content) #578

merged 4 commits into from
Oct 23, 2023

Conversation

carletex
Copy link
Member

Fixes #576

This feels good haha. Please check that I'm not missing anything that ExampleUI was using and I didn't remove.

We could wait to merge this until we have a v0.1 of scaffold-eth/se-2-docs#25.... or not 😇

P.S. Shoutout to @rin-st who did a great job implementing it in the first place :)

@damianmarti
Copy link
Member

Fixes #576

This feels good haha. Please check that I'm not missing anything that ExampleUI was using and I didn't remove.

We could wait to merge this until we have a v0.1 of scaffold-eth/se2-docs#25.... or not 😇

P.S. Shoutout to @rin-st who did a great job implementing it in the first place :)

It always feels good to remove things :-)

@damianmarti
Copy link
Member

@carletex I found a small comment about the example UI in the README page:

Visit your app on: http://localhost:3000. You can interact with your smart contract using the contract component or the example ui in the frontend.

@carletex carletex force-pushed the 576#remove-example-ui branch from dcb9576 to f3486b5 Compare October 19, 2023 15:43
@carletex
Copy link
Member Author

I found a small comment about the example UI in the README page:

Good catch Damu!

Removed it on f3486b5

technophile-04
technophile-04 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove react-fast-marquee

scaffold-eth-2/packages/nextjs/package.json

Line 30 in aec2b8c

"react-fast-marquee": "^1.3.5",

and maybe this rule too ( not sure about this weather to keep this or not) :

scaffold-eth-2/packages/nextjs/.eslintrc.json

Line 14 in aec2b8c

"@next/next/no-page-custom-font": ["off"]

apart from this I think everything is removed 🙌

This feels good haha. Please check that I'm not missing anything that ExampleUI was using and I didn't remove.

We could wait to merge this until we have a v0.1 of scaffold-eth/se2-docs#25.... or not 😇

I think maybe we could merge this 🙌 since we already have all isolated examples of hooks in docs.... not that verbose how it will be recipe section but I think they are good

P.S. Shoutout to @rin-st who did a great job implementing it in the first place :)

🫡🫡

Tysm Carlos 🙌

damianmarti
damianmarti approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@damianmarti damianmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @carletex !!

@rin-st
Copy link
Member

rin-st commented Oct 19, 2023

Looks good to me!
F 🫡

@carletex
Copy link
Member Author

Good eye @technophile-04 !! Remove the lib and the eslint rule.

Thanks all for the review!

I'll let you guys merge after reviewing the last two commits :)

@technophile-04
Copy link
Collaborator

LGTM! Tysm Carlos and all for reviews !! Merging this 🙌

@technophile-04 technophile-04 merged commit 8cd5249 into main Oct 23, 2023
1 check passed
@technophile-04 technophile-04 deleted the 576#remove-example-ui branch October 23, 2023 02:37
@technophile-04 technophile-04 mentioned this pull request Oct 23, 2023
Merged
carletex added a commit that referenced this pull request Oct 23, 2023
@technophile-04 @FilipHarald
@gskril @rin-st @carletex
backmerge latest change to cli (#582)
30d9000 
* Tweak DaisyUI `link` (#560)

* Improve ENS support (accept all TLDs) (#563)

* fix: memo history events (#565)

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>

* Extract header menu links (#570)

* Move Block Explorer to footer (#574)

* Remove ExampleUI (pages, components, assets, content) (#578)

* update wagmi, viem, rainbowkit (#580)

* add zkSync, scroll & polygonZkEvm to foundry.toml

* add changeset

---------

Co-authored-by: Filip Harald <Filip.harald@gmail.com>
Co-authored-by: Greg <35093316+gskril@users.noreply.github.com>
Co-authored-by: Rinat <rinat@hey.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technophile-04 technophile-04 technophile-04 approved these changes

@rin-st rin-st rin-st approved these changes

@damianmarti damianmarti damianmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Re)move Example UI
4 participants
@carletex @damianmarti @rin-st @technophile-04