Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of tailwind link-class with some extensions #560

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

FilipHarald
Copy link
Contributor

Description

Changes so that the Footer uses link from tailwind. Also adding some customization to it.

Additional Information

Related Issues

Implements the feedback from @carletex here: #551

Your ENS/address: harmont.eth

@FilipHarald
Copy link
Contributor Author

@carletex , I took the liberty of putting opacity 80%, it wasn't visible in light-mode otherwise. Other than that I have implemented to what I think you meant.

I'm not sure if it's optimal to have the extension listed twice. But I didn't get it to work putting it just in the config.theme.extend. Perhaps you could point me in the right direction?

@carletex
Copy link
Member

It's looking great @FilipHarald, thanks!

Could you fix the prettier issues? You should be able to configure your IDE so it gets our prettier config and apply it on save.

image

@FilipHarald
Copy link
Contributor Author

Yepp, fixed it now. I have it working for .ts-files but for some reason it doesn't work for .js. But I'm sure that is on my own configs that needs some adjusting.

@carletex
Copy link
Member

Good stuff @FilipHarald

Thanks!!

@carletex carletex merged commit cd06684 into scaffold-eth:main Oct 10, 2023
1 check passed
carletex added a commit that referenced this pull request Oct 12, 2023
* Tweak DaisyUI `link` (#560)

* Improve ENS support (accept all TLDs) (#563)

* fix: memo history events (#565)

* update developer guide with backmerge-main instructions

* add changeset

---------

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Filip Harald <Filip.harald@gmail.com>
Co-authored-by: Greg <35093316+gskril@users.noreply.github.com>
Co-authored-by: Rinat <rinat@hey.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
carletex added a commit that referenced this pull request Oct 23, 2023
* Tweak DaisyUI `link` (#560)

* Improve ENS support (accept all TLDs) (#563)

* fix: memo history events (#565)

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>

* Extract header menu links (#570)

* Move Block Explorer to footer (#574)

* Remove ExampleUI (pages, components, assets, content) (#578)

* update wagmi, viem, rainbowkit (#580)

* add zkSync, scroll & polygonZkEvm to foundry.toml

* add changeset

---------

Co-authored-by: Filip Harald <Filip.harald@gmail.com>
Co-authored-by: Greg <35093316+gskril@users.noreply.github.com>
Co-authored-by: Rinat <rinat@hey.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
@FilipHarald FilipHarald deleted the feat/more_lively_links branch November 11, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants