Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated footer to use BuidlGuidl logo #551

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Conversation

FilipHarald
Copy link
Contributor

Description

Updated the footer with BG-logo.
Screenshot from 2023-09-30 15-26-26
Screenshot from 2023-09-30 15-26-15

simplescreenrecorder-2023-09-30_15.25.30.mp4

Additional Information

Related Issues

Logotypes and ideas taken from this discussion.

Your ENS/address: harmont.eth

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really nice and clean !! Tysm @FilipHarald for the PR !! also thanks to Rinat and Zak for review 🙌

@carletex
Copy link
Member

carletex commented Oct 3, 2023

Good stuff @FilipHarald ! And thanks all for the review.

  • Pushed a little tweak to match the other links in the footer: 6fd539f

One improvement that we could make in another PR: I miss a transition when hovering a link (like changing the opacity to 90% with a 300ms transition). We could just add it to the .link:hover selector... or create a custom class in tailwind.config.js. Also, maybe changing the footer link to use the link class? (instead of manually setting the underline. I like the offset, so we might want to set the default for the link class... or the new custom class.). I know, little things, but it just makes the codebase more consistent!

@carletex carletex merged commit b33a87d into scaffold-eth:main Oct 3, 2023
1 check passed
@FilipHarald
Copy link
Contributor Author

Thank you!

OK, I'll have a look at it when I have time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants