Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usehooks-ts patch is not applied on vercel deployment #706

Closed
technophile-04 opened this issue Feb 7, 2024 · 2 comments
Closed

usehooks-ts patch is not applied on vercel deployment #706

technophile-04 opened this issue Feb 7, 2024 · 2 comments

Comments

@technophile-04
Copy link
Collaborator

Description :

Because of #419 (comment), usehooks-ts patch which is at root of the repo is not applied.

This breaks the storing and retrieving of user-selected theme it always uses user system theme when the page is refreshed instead of remembering user choice.

Example : https://se2-structs.vercel.app/

Originally reported here => scaffold-eth/se-2-challenges#131 (review)

@technophile-04
Copy link
Collaborator Author

technophile-04 commented Feb 7, 2024

PS: there seems some recent relases of usehooks-ts https://github.com/juliencrn/usehooks-ts/releases maybe we try updgrading it and see if it works without patch

also the issue which lead us to create a patch seems to be fixed too juliencrn/usehooks-ts#251 (comment)

@carletex
Copy link
Member

carletex commented Feb 7, 2024

yarn.lock is haunting us! haha

Let's test if the new version fixes it!

Thanks Shiv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants