Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies Aug 24 #917

Closed
wants to merge 13 commits into from
Closed

Update dependencies Aug 24 #917

wants to merge 13 commits into from

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Aug 26, 2024

Description

  • Updates dependencies
  • Adds react-copy-to-clipboard types definition since after updates types breaks
  • updated husky script and pre-commit. See "How to migrate" block https://github.com/typicode/husky/releases/tag/v9.0.1
  • removed nextjs/out folder from formatting
  • Adds yarn plugin that helps to update all the packages. How to use: yarn upgrade-interactive

There are still possible updates:
image

But I think we don't need to touch it for now:

  • abitype breaks types since it differs from viem
  • chai breaks hardhat
  • eslint/prettier packages - revert #875 #905
  • types/node v18 since we use node v18 for now

Tried all the scripts from root package.json and looks like everything works as expected

Additional Information

@technophile-04
Copy link
Collaborator

Lol I am afraid and procrastinating to test this

Probably we could have divided this in to :

  1. updating Wagmi , Viem, Abitype, Rainbowkit versions
  2. Next, react, react-dom all realted package versions
  3. Typescript, eslint, eslint typescript etc versions
  4. Hardhat updagrades
  5. Maybe packages which has major bump a separate PR for each example:
  6. then rest of remaining small packages?

Maybe sounds a lot of work but this way we make sure there are less unrecognised bugs and if we find a bug its easy to find out to which thing it belongs? because sometimes really wired bug appear like #555 (comment) and hard to debug too

but lol maybe I am being too much cautious

Comment on lines 33 to 34
"use-debounce": "^10.0.3",
"usehooks-ts": "^3.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh probably if usehooks works nicely now, we could remove use-debounce? since we have a debounce hook in usehookts.ts?

https://usehooks-ts.com/react-hook/use-debounce-value

@rin-st
Copy link
Member Author

rin-st commented Aug 30, 2024

Probably we could have divided this in to :

You mean create pr for every step, test it, backmerge to create-eth, test it, create new one etc? Looks very slow, but if you want I can create different pr's it's easy.


As an option, you can for example test commit by commit, which is divided into logical blocks. It's not ideal, but I think it's ok. And then only bugfixes prs if needed

@rin-st
Copy link
Member Author

rin-st commented Aug 30, 2024

Are you getting this warning on nextjs terminal btw?

<w> [webpack.cache.PackFileCacheStrategy] Caching failed for pack: Error: Unable to snapshot resolve dependencies

Didn't notice it first. This doesn't help.

Upd. getting this warning on main too 🤷‍♂️

@rin-st
Copy link
Member Author

rin-st commented Aug 30, 2024

Last react-query version 5.53.1 (3 hours ago) breaks requests with BigInts in response (for example requesting balance of the connected wallet). I need to update structuralSharing or fix serializing or probably they will change this behavior on next versions. I'll update it later

@rin-st
Copy link
Member Author

rin-st commented Sep 5, 2024

Last react-query version 5.53.1 (3 hours ago) breaks requests with BigInts in response (for example requesting balance of the connected wallet). I need to update structuralSharing or fix serializing or probably they will change this behavior on next versions. I'll update it later

Throwing error was fixed in 5.53.3 so Balance will work as expected, but without ee3400f warnings still will be on the console

@rin-st rin-st marked this pull request as draft September 5, 2024 18:36
@rin-st
Copy link
Member Author

rin-st commented Sep 5, 2024

Lol I am afraid and procrastinating to test this

Probably we could have divided this in to :

  1. updating Wagmi , Viem, Abitype, Rainbowkit versions

  2. Next, react, react-dom all realted package versions

  3. Typescript, eslint, eslint typescript etc versions

  4. Hardhat updagrades

  5. Maybe packages which has major bump a separate PR for each example:

  6. then rest of remaining small packages?

Maybe sounds a lot of work but this way we make sure there are less unrecognised bugs and if we find a bug its easy to find out to which thing it belongs? because sometimes really wired bug appear like #555 (comment) and hard to debug too

but lol maybe I am being too much cautious

Yes, I think it will be easier to do it that way. Starting to make these smaller prs

Also thinking about 7. Up yarn to last version (4.4.1 currently) but need to check stability, speed and so on, not sure it's worth it

This was referenced Sep 5, 2024
@rin-st
Copy link
Member Author

rin-st commented Sep 19, 2024

Nextjs still doesn't support eslint v9, so skipping step 3 for now vercel/next.js#64409 , but I think up TS version later. See also #905

@rin-st rin-st mentioned this pull request Sep 19, 2024
2 tasks
@rin-st rin-st mentioned this pull request Oct 10, 2024
2 tasks
@rin-st
Copy link
Member Author

rin-st commented Oct 28, 2024

Resolved, see referenced PRs

@rin-st rin-st closed this Oct 28, 2024
@rin-st rin-st deleted the update-deps-08-24 branch December 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants