-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies Aug 24 #917
Conversation
Lol I am afraid and procrastinating to test this Probably we could have divided this in to :
Maybe sounds a lot of work but this way we make sure there are less unrecognised bugs and if we find a bug its easy to find out to which thing it belongs? because sometimes really wired bug appear like #555 (comment) and hard to debug too but lol maybe I am being too much cautious |
packages/nextjs/package.json
Outdated
"use-debounce": "^10.0.3", | ||
"usehooks-ts": "^3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh probably if usehooks works nicely now, we could remove use-debounce? since we have a debounce hook in usehookts.ts?
You mean create pr for every step, test it, backmerge to create-eth, test it, create new one etc? Looks very slow, but if you want I can create different pr's it's easy. As an option, you can for example test commit by commit, which is divided into logical blocks. It's not ideal, but I think it's ok. And then only bugfixes prs if needed |
Are you getting this warning on nextjs terminal btw?
Didn't notice it first. This doesn't help. Upd. getting this warning on |
Last |
Throwing error was fixed in 5.53.3 so Balance will work as expected, but without ee3400f warnings still will be on the console |
Yes, I think it will be easier to do it that way. Starting to make these smaller prs Also thinking about 7. Up |
Nextjs still doesn't support eslint v9, so skipping step 3 for now vercel/next.js#64409 , but I think up TS version later. See also #905 |
Resolved, see referenced PRs |
Description
react-copy-to-clipboard
types definition since after updates types breakshusky
script and pre-commit. See "How to migrate" block https://github.com/typicode/husky/releases/tag/v9.0.1nextjs/out
folder from formattingyarn upgrade-interactive
There are still possible updates:
But I think we don't need to touch it for now:
Tried all the scripts from root package.json and looks like everything works as expected
Additional Information