-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polygonZkEvm and polygonZkEvmTestnet and update wagmi/core #309
Conversation
refactor: small improvement for empty contracts (scaffold-eth#264)
…fig. updated wagmi/core to 12.10
Hi - this is my first functional PR - please guide me if i need to add / remove anything (like is the yarn.lock supposed to be included??) Also not sure where I am supposed to tag or add reviewers so I will here - Hi @austintgriffith could you guide me here? thanks. (do I need to create a work item to associate?) |
Will play around a bit with it to see if there's anything that needs to be taken into account with the |
Thank you @sverps for your feedback! Please note I only deployed to testnet - working on bridging to deploy to mainnet tonight. (I probably should have waited to raise the pr until then maybe). Thanks |
Tysm @OwlWilderness, I think we should be really be conscious of package updation especially Saying this because I think Wagmi
Yup it would be really great if we get verify working Marking this as a draft until we get verify working and |
Hi @technophile-04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey tysm @OwlWilderness 🙌, We actually updated the wagmi version so reverted the other changes and just kept the hardhat.config.ts
changes
Thank you @technophile-04! I knew wagmi was going in and thought to update this PR but wasn't paying too much attention - so I really appreciate you reverting those commits and merging this. |
#310 Add polygonZkEvm and polygonZkEvmTestnet and update wagmi/core