-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compatibility with SAFE #346
Conversation
I came here to post this same issue. It would be great if SE2 builds worked as safe apps out of the box. 👀 maybe it already is! |
I think this PR is ready to merge 🙌, updated the logic so now its alot simpler and direct Here is the test app link : https://safe-goerli.vercel.app (can be tested on gorerli safe I also tested auto connect nicely just to be sure that we don't break anything 🙌 |
Gj! |
didn't get this 😅, like when you disconnect it will disconnect and when you click connect wallet it will show Screen.Recording.2023-09-30.at.7.55.17.PM.movAlso notice |
Tysm all for review merging this 🙌 |
add out of box compatibility with SAFE{Wallet} (scaffold-eth#346)
add out of box compatibility with SAFE{Wallet} (scaffold-eth#346)
Description
It would be really great if we make SE-2 compatible with Gnosis SAFE by default as soon as it's deployed.
Screen.Recording.2023-05-14.at.5.10.34.PM.mov
Try adding it as a custom app on SAFE goerli -> https://xx-ecru.vercel.app
Note: To make it work you have to deploy your Dapp first. It won't work if you are running
localhost
, we can make it work but we may need to configure CORS https://docs.safe.global/learn/safe-apps/get-started#cors and I think CORS options suggested in safe-docs are a bit harsh and don't like setting them as default in SE-2.I originally added it to ETH-Splitter and thought it might be great if we provide SAFE compatibility out of the box , but feel free to close it 🙌
Additional Information
Your ENS/address: shivbhonde.eth