Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grid and grid-flow class to li manually #510

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

technophile-04
Copy link
Collaborator

Description

This is a hacky solution for #509

Copy link
Member

@damianmarti damianmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@technophile-04
Copy link
Collaborator Author

Just pushed a few minor tweaks :

  1. 1551743 -> Fixes Scaffol-eth logo wraps when not in full screen or in smaller screens :
    Screenshot 2023-08-29 at 12 56 28 PM

this has been bugging from long and lol also Austin has the thing broken always because his brwoser window is always smaller while presenting

  1. 3a99b66 -> there was kind of flickering when you switch tabs :
Screen.Recording.2023-08-29.at.12.46.12.PM.mov

so now the behaviour is the same as we had in daisyUI v2 checkout this https://chall-accepted-builders.vercel.app/

  1. eaa9364 -> capitalized eth in logo since that what we are using eg in READEME.md name🙌

Notes regarding hacky solution :

  1. Yeah it's PITA that we have to add these classes manually Instead they should been added by default similar to the way running on localhost but this seems problem with daisyUI. Created an issue on daisyUI -> bug: menu break in NextJs production build saadeghi/daisyui#2303

  2. This problem does seem to get solved when you update the next version to the latest 13.4.X and also 13.4.x is backward compatible (this is what they say) but need to patiently see if there are any direct breaking and migrate slowly will research on this 🙌

Tysm guys!! Merging this for now, we can keep an eye on saadeghi/daisyui#2303 if its get solved if not we can migrate to latest version of next slowly 🙌

@technophile-04 technophile-04 merged commit 0b371df into main Aug 29, 2023
@technophile-04 technophile-04 deleted the daisy-hacky-menu branch August 29, 2023 07:50
@carletex
Copy link
Member

this has been bugging from long and lol also Austin has the thing broken always because his brwoser window is always smaller while presenting

THANK YOU. I've been having nightmares about this haha

damianmarti pushed a commit that referenced this pull request Sep 7, 2023
* Fix RainbowKitCustomConnectButton dropdown styles (#500)

* chore: footer missalignment & home page on small screens  (#502)

Co-authored-by: CJ <53488449+0xChijoke@users.noreply.github.com>

* Update and typescript version (#499)

* update typescript and viem version

* update next config

* fix: header links wrapping icons and text (#510)

* Fix typos in useScaffoldContractWrite logs (#512)

* fix: spelling in test file name (#522)

* add suport for verify in foundry similar to hardhat

* update git task title when using foundry

* add changeset

* update changeset

---------

Co-authored-by: Rinat <rinat@hey.com>
Co-authored-by: CJ <53488449+0xChijoke@users.noreply.github.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
technophile-04 added a commit to Anurag-Raut/se-2 that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants