Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from react-blockies to blo #538

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Move from react-blockies to blo #538

merged 2 commits into from
Sep 22, 2023

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Sep 21, 2023

Description

Move from react-blockies to blo, for a faster and more precise rendering of the identicons.

Before:
image

After:
image

Before:
image

After:
image

Before:
image

After:
image

Additional Information

My ENS/address: pierre.eth

@carletex
Copy link
Member

This looks really good @bpierre. Thanks!!

Good job building the lib ;)

Let us test a bit more & do a quick due diligence and will merge.

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm @bpierre, This is really great !!

It indeed renders identicons nicely and more correctly!

blo react-blockies
Screenshot 2023-09-21 at 10 23 46 PM Screenshot 2023-09-21 at 10 23 22 PM

The above images are when you use Address component with size="2xl", blo example looks complete accurate as compared to react-blockies

Look really good to me !

Just cc @carletex(edit : lol he already commented) @rin-st @damianmarti once since it is a pretty new libraray, but on my testing everything worked similarly to react-blockies 🙌

@bpierre
Copy link
Contributor Author

bpierre commented Sep 21, 2023

Awesome 🥳 💕

@rin-st
Copy link
Member

rin-st commented Sep 21, 2023

Looks good to me 👍

@carletex carletex merged commit 44c5d50 into scaffold-eth:main Sep 22, 2023
1 check passed
@bpierre bpierre deleted the blo branch September 22, 2023 12:30
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants