Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up rainbowkit version to 1.3.5 #719

Merged
merged 1 commit into from
Feb 12, 2024
Merged

up rainbowkit version to 1.3.5 #719

merged 1 commit into from
Feb 12, 2024

Conversation

technophile-04
Copy link
Collaborator

Description

It seems that there was some changes related to i18-js, which was fixed at @rainbow-me/rainbowkit@1.3.4 so updated to 1.3.5(which is latest 1.x version) and it does seem to solve the issue

fixes #718

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it and solved the Vercel issue, and vercel deployment is working fine, but then realized that in my local deployment Debug tab keeps flickering.

The flickering happends in this branch and also in #702 when I tried upgrading rainbow to 1.3.5 also

EDIT: Realized that it was working fine in incognito, CTRL+F5 was not enough but rebooted pc and it is working totally fine, so I guess it was some very edge case, maybe clicking tab while build was still going or something, will try to reproduce but approving 🙌

Check gif

rainbow-135-flickering

@technophile-04
Copy link
Collaborator Author

Realized that it was working fine in incognito, CTRL+F5 was not enough but rebooted pc and it is working totally fine

Ohh does not happen to me, but one cause maybe I could think of is since we are tinkering with #707 which kind of affects locastorage logic and when we switch to main or this branch where handling of data in localstorage is bit different, due this difference there might be some inconsistency which might have occured.

Manually trying to reproduce:
Screen.Recording.2024-02-13.at.12.26.25.AM.mov

But yeah lol that's my wild guess but this shouldn't happen to normal users, its just might happen with us (contributors) who are switching between different branches (where localstroage logic is changing)

But Tysm Pablo, merging this 🙌

@technophile-04 technophile-04 merged commit 0fd0a55 into main Feb 12, 2024
1 check passed
@technophile-04 technophile-04 deleted the up-rainbow-version branch February 12, 2024 19:21
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
kmjones1979 added a commit that referenced this pull request Feb 15, 2024
* Add Optimism Sepolia config (#711)

* Use arbitrumSepolia instead of Goerli (#716)

* up rainbowkit version to 1.3.5 (#719)

* removing lock file

* use next-themes to handle theme and update usehooks-ts (#707)

* Feat: Better complex struct inputs (#702)

* improve debug struct UI (#726)

* add basic example to show connected address (#721)

---------

Co-authored-by: winnsterx <46658657+winnsterx@users.noreply.github.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: vercel deployments fails due to rainbowkit
2 participants