Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli weekly backmerge #796

Merged
merged 14 commits into from
Apr 8, 2024
Merged

Cli weekly backmerge #796

merged 14 commits into from
Apr 8, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Apr 4, 2024

Description

Copy link
Collaborator Author

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nicely and everything does seem to work, but would love if someone just give a try 🙌

(Vercel-CLI) : https://test-hardhat-99.vercel.app

(Repo connected to GH) : https://test-hardhat-101-vercel-nextjs.vercel.app/

@rin-st
Copy link
Member

rin-st commented Apr 5, 2024

deployment works for me, but

gh-actions fail for new foundry project. I think it's already known bug?
example

@technophile-04
Copy link
Collaborator Author

gh-actions fail for new foundry project. I think it's already known bug?

Ohh yup, we do have an open issue for it #607

@rin-st
Copy link
Member

rin-st commented Apr 6, 2024

Ohh yup, we do have an open issue for it #607

Got it, thanks!

@technophile-04
Copy link
Collaborator Author

Thanks @rin-st, Merging this 🙌

@technophile-04 technophile-04 merged commit 3be84f9 into cli Apr 8, 2024
@technophile-04 technophile-04 deleted the cli-weekly-backmerge branch April 8, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants