Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address components copy icon on small screens #864

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

MukulKolpe
Copy link
Contributor

@MukulKolpe MukulKolpe commented Jun 11, 2024

Description

Fixed the address components copy icon and "connected address" + Address component alignment for smaller screen size.

Scaffold-ETH.2.App.-.Google.Chrome.2024-06-14.03-50-38.mp4

Additional Information

Related Issues

Closes #863

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address: 0xfC001B20Db6195b148cfc4F7685091931D93cD93

@MukulKolpe
Copy link
Contributor Author

@technophile-04, let me know if there are any changes that should be made.

@MukulKolpe
Copy link
Contributor Author

Thank you, @carletex. I've made the suggested changes and updated the video. Please let me know if there are any further changes.

@technophile-04
Copy link
Collaborator

Hey thanks @MukulKolpe ! Added flex-shrink-0 to both Icons as well since they were shrinking in smaller device in Transaction receipt :

Before After
Screenshot 2024-06-17 at 11 51 13 AM Screenshot 2024-06-17 at 11 51 48 AM

@technophile-04 technophile-04 merged commit e23ab4d into scaffold-eth:main Jun 17, 2024
1 check passed
@MukulKolpe MukulKolpe deleted the copy-address branch June 18, 2024 06:37
zapaz pushed a commit to zapaz/scaffold-eth-fleek that referenced this pull request Jul 3, 2024
Co-authored-by: Shiv Bhonde <shivbhonde04@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Address component copy icon disappear's
3 participants