Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unecessary logs for decoding tx in block-explorer #985

Merged

Conversation

FilipHarald
Copy link
Contributor

Description

Instead of logging errors for expected behavior it adds 'Unknown ABI' to function name.

Before
Screenshot from 2024-11-15 11-42-04

After
Screenshot from 2024-11-15 11-42-37

Additional Information

Related Issues

Closes #984

Your ENS/address: harmont.eth

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FilipHarald for catching and fixing it!

EDIT: Just read the #984 so all good, just added a couple of comments

@technophile-04 technophile-04 merged commit fb2c996 into scaffold-eth:main Nov 21, 2024
1 check passed
@FilipHarald FilipHarald deleted the fix_decodeTransactionData branch November 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: block explorer decodeTransactionData is brute forcing decode, and producing unecessary error-msgs
2 participants