-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove clone command + add npx install #993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the below commands are hardhat specific
Line 46 in e5a666b
This command starts a local Ethereum network using Hardhat. The network runs on your local machine and can be used for testing and development. You can customize the network configuration in `hardhat.config.ts`. |
Umm maybe make description for those 3 magic commands a bit more generic and then point to docs directly?
\
Sounds good, I can tweak them if you want |
Tried to remove all the references to specific configuration of Hardhat, and pointed to the docs instead. Also pushed a couple of small tweaks:
Let me know if you prefer to remove any of that, or go more minimal in the Readme. Thanks! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this looks great for first iteration!
As we discussed yesterday, we are moving away from SE-2 clone method. The first step is to remove it from the docs / READMEs / etc.
Related scaffold-eth/scaffoldeth.io#41