Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clone command + add npx install #993

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Remove clone command + add npx install #993

merged 7 commits into from
Nov 22, 2024

Conversation

carletex
Copy link
Member

As we discussed yesterday, we are moving away from SE-2 clone method. The first step is to remove it from the docs / READMEs / etc.

Related scaffold-eth/scaffoldeth.io#41

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the below commands are hardhat specific

This command starts a local Ethereum network using Hardhat. The network runs on your local machine and can be used for testing and development. You can customize the network configuration in `hardhat.config.ts`.

Umm maybe make description for those 3 magic commands a bit more generic and then point to docs directly?
\

@Pabl0cks
Copy link
Collaborator

Umm maybe make description for those 3 magic commands a bit more generic and then point to docs directly?

Sounds good, I can tweak them if you want

@carletex
Copy link
Member Author

Sounds good, I can tweak them if you want

Sounds good.

Hardhat is also mentioned here

image

Maybe we should keep the README minimal and just link to the docs

@Pabl0cks
Copy link
Collaborator

Sounds good.

Tried to remove all the references to specific configuration of Hardhat, and pointed to the docs instead. Also pushed a couple of small tweaks:

  • Add foundry to tech stack
  • Add extensions hint in installation setup

Let me know if you prefer to remove any of that, or go more minimal in the Readme. Thanks! 🙌

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this looks great for first iteration!

@technophile-04 technophile-04 merged commit 812303a into main Nov 22, 2024
1 check passed
@technophile-04 technophile-04 deleted the remove-clone branch November 22, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants