Challenge 4 migration to extension

[damianmarti]

Challenge 4 migrated to an extension following #234

Install from create-eth repo with:

yarn cli -e scaffold-eth/se-2-challenges:ch4-extension-init

closes #241

[rin-st]

Thanks Damu! Added small comments

Also found one bug. Steps to reproduce

• add solution contract and also uncomment code on deployment file
• add eth from faucet
• add "1" to "tokenToEth" input. Press "Send"

Result before (text is easy to understand):

Result in this extension:

Decoded signature:

https://openchain.xyz/signatures?query=0xfb8f41b2

[damianmarti]

Thanks Damu! Added small comments

Also found one bug. Steps to reproduce

• add solution contract and also uncomment code on deployment file
• add eth from faucet
• add "1" to "tokenToEth" input. Press "Send"

Result before (text is easy to understand):

Result in this extension:

Decoded signature:

https://openchain.xyz/signatures?query=0xfb8f41b2

Thanks @rin-st for the review and great catch!

I fixed it by adding a package.json to hardhat with @openzeppelin/contracts.

The new @openzeppelin/contracts v5 uses custom errors and our getParsedError is not able to show a nice message in this case. We should add an issue to fix it.

[rin-st]

Lgtm! Created an issue to fix that error, see above.

Thank you @damianmarti !

[Pabl0cks]

`packages\nextjs\app\events\page.tsx` this is getting rendered badly in my instance readme:

In `packages
extjsappeventspage.tsx`

[Pabl0cks]

I think there was a backslash escaping problem here, was still seeing it wrong.

As a quick fix just changed the backslash for regular slash in a9a4a12 since we're using regular slashes in other folders.

[Pabl0cks]

Nice job Damu!! 🙌 The challenge is working great to me.

Just added some comments with nitpick format errors in the Readme from my instance.

Also just to comment it, I received this message when I tried to yarn vercel. Never saw it before, I needed to do yarn vercel --yes:

$ yarn vercel
Vercel CLI 39.1.3
> NOTE: The Vercel CLI now collects telemetry regarding usage of the CLI.
> This information is used to shape the CLI roadmap and prioritize features.
> You can learn more, including how to opt-out if you'd not like to participate in this program, by visiting the following URL:
> https://vercel.com/docs/cli/about-telemetry
Error: Command `vercel deploy` requires confirmation. Use option "--yes" to confirm.

[rin-st]

Also just to comment it, I received this message when I tried to yarn vercel. Never saw it before, I needed to do yarn vercel --yes:

Could you check if it asking it for new deployments? Probably you need to create new instance, or is it asked just one time?

Also, try it with env variables like in this PR

[Pabl0cks]

Could you check if it asking it for new deployments? Probably you need to create new instance, or is it asked just one time?

Also, try it with env variables like in this scaffold-eth/scaffold-eth-2#1012

Just created a fresh instance of another extension and seems like today I'm getting another error, without the telemetry promt:

Tried with PR but still get the message, I needed to add the --yes in order to make it work

[rin-st]

from the docs :

The --yes option can be used to skip questions you are asked when setting up a new Vercel project. The questions will be answered with the provided defaults, inferred from vercel.json and the folder name.

So as I understand it should be a question before asking for --yes. Looks like a vercel cli bug.

---

Could you please try one more thing for the last project:

yarn vercel telemetry disable

and then

yarn vercel

Is it still asking for --yes?

[damianmarti]

Nice job Damu!! 🙌 The challenge is working great to me.

Just added some comments with nitpick format errors in the Readme from my instance.

Thanks @Pabl0cks for the review!!

I used a clean README and pushed the changes. There was an issue with the previous one due to auto-formatting from my IDE. Please, let me know if the formatting is ok now.

[damianmarti]

Also just to comment it, I received this message when I tried to yarn vercel. Never saw it before, I needed to do yarn vercel --yes:

$ yarn vercel
Vercel CLI 39.1.3
> NOTE: The Vercel CLI now collects telemetry regarding usage of the CLI.
> This information is used to shape the CLI roadmap and prioritize features.
> You can learn more, including how to opt-out if you'd not like to participate in this program, by visiting the following URL:
> https://vercel.com/docs/cli/about-telemetry
Error: Command `vercel deploy` requires confirmation. Use option "--yes" to confirm.

I'm using Vercel CLI 37.4.2 and it's working fine. Maybe some wrong project configuration. Can you please try to do it from a fresh project?

[Pabl0cks]

I'm using Vercel CLI 37.4.2 and it's working fine. Maybe some wrong project configuration. Can you please try to do it from a fresh project?

Realized it was only happening to my Git Bash (on desktop). The rest of terminals were working well, even Git Bash on laptop.
Downloaded and installed last version of Git Bash and is working nicely on desktop without --yes prompt🙏

[Pabl0cks]

Looking good to merge! TY @damianmarti