-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default failbacks #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paltman This is another thing where I feel like our acceptance criteria in Trello is not thorough enough.
Looking at
https://deploy-preview-37--explorehomer-dev.netlify.app/reader?urn=urn%3Acts%3AgreekLit%3Atlg0012.tlg001.msA-folios%3A12r.1.1-12r.1.25, we have better fallbacks on the widgets:
But not on the display mode (e.g. sentence alignments here):
or the metrical annotations:
(We do have a good fall back on the folio images though already)
The first thing that's clear is that we're completely inconsistent in the styling of the widget fallback.
My slight preference is the Named Entities variant. I certainly prefer the smaller font size, less indentation, and no period. Not sure what which I prefer between "available" or "found" or neither. |
I'll make a component called |
@jtauber everything is now the same font/size/padding/message. It's a default message in a slot so we can override with specific language. Just let me know what language you want in what widget/place. |
For the side widgets, I'd drop the I understand the centering and margins are needed when in the reader widget (metrical annotation and folios) but in side widgets they take up a bit too much space and draw too much attention. |
@jtauber fixed |
# Conflicts: # src/reader/components/ReaderView.vue # src/widgets/WordListWidget.vue
No description provided.