Handle NAC edge-case #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacobwegner
commented
Jul 2, 2020
jacobwegner
commented
paltman
reviewed
Jul 6, 2020
| } from '@scaife-viewer/scaife-widgets'; | ||
|
|
||
| export default { | ||
| extends: NewAlexandriaWidget, |
There was a problem hiding this comment.
This is cool. Didn't know it was possible to do this.
paltman
reviewed
Jul 6, 2020
|
|
||
| We may also find that the Vue Composition API | ||
| (https://composition-api.vuejs.org/) lends itself to these types of | ||
| customizations. |
There was a problem hiding this comment.
Yes! composition API is going to change everything for us on Scaife.
paltman
reviewed
Jul 6, 2020
paltman
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.