Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike to introduce Apollo #52

Merged
merged 21 commits into from
Jul 14, 2020
Merged

Spike to introduce Apollo #52

merged 21 commits into from
Jul 14, 2020

Conversation

jacobwegner
Copy link
Contributor

No description provided.

@jacobwegner
Copy link
Contributor Author

@paltman take a look at each of the following commits:

  • c1a4761 introduces the apollo object
  • 930b563 refactors the query to use name matching (so we can access the data via whatever name we want (e.g. libraryTree), rather than the name of the response from GraphQL
  • a9f0ad8 uses that libraryTree from the component data (rather than the $apolloData handler which is still useful for getting at loading information)
  • b255931 removes the computed property and just works off of the libraryTree data prop

I'll let you decide if you wan to take this further / explore with ApolloComponent, but I think this at least answers the question of "how does vue-apollo query syntax map onto what we've been doing so far?"

@paltman paltman marked this pull request as ready for review July 14, 2020 17:20
@paltman paltman merged commit c16b791 into develop Jul 14, 2020
@paltman paltman deleted the spike-apollo branch July 14, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants