Skip to content

Commit

Permalink
Bug fix for configuration option INTEL:HSW/BDW (wrf-model#1645)
Browse files Browse the repository at this point in the history
TYPE: bug fix

KEYWORDS: Intel, ifort, HWS, BDW, bug

SOURCE: GitHub user jw500

DESCRIPTION OF CHANGES:
Problem: When a user chooses one of the following configuration options for the Intel (HWS/BDW) compiler,
`64. (serial)  65. (smpar)  66. (dmpar)  67. (dm+sm)   INTEL (ifort/icc): HSW/BDW`
they will instead be given a configuration for the corresponding option for basic Intel.
`13. (serial)  14. (smpar)  15. (dmpar)  16. (dm+sm)   INTEL (ifort/icc)`

The configure.wrf file will read
```
#### Architecture specific settings ####

# Settings for    Linux x86_64 ppc64le i486 i586 i686, ifort compiler with icc  (serial)

DESCRIPTION     =       INTEL ($SFC/$SCC)
```

This is the result of "Add missing compiler name for two Intel config stanzas" wrf-model#1326, hash [commit 0a9c2eb](wrf-model@0a9c2eb)

Solution:
Modified configure.defaults to ensure the "#ARCH" lines were not identical between HSW/BDW Intel and basic Intel options.

LIST OF MODIFIED FILES: 
M    arch/configure.defaults

TESTS CONDUCTED: 
1. Mods fix the issue. A configuration was done to test this.
2. Jenkins tests are all passing.

RELEASE NOTE: Beginning with V4.2.2 a bug was introduced that prevented users from configuring the model with the  "INTEL (ifort/icc): HSW/BDW" option. This is now resolved.
  • Loading branch information
kkeene44 authored and vlakshmanan-scala committed Apr 4, 2024
1 parent fef0ee7 commit 7ac0d6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/configure.defaults
Original file line number Diff line number Diff line change
Expand Up @@ -1834,7 +1834,7 @@ RLFLAGS =
CC_TOOLS = $(SCC)

###########################################################
#ARCH Linux x86_64 ppc64le i486 i586 i686, ifort compiler with icc #serial smpar dmpar dm+sm
#ARCH Linux HSW/BDW x86_64 ppc64le i486 i586 i686, ifort compiler with icc #serial smpar dmpar dm+sm
#
DESCRIPTION = INTEL ($SFC/$SCC): HSW/BDW
DMPARALLEL = # 1
Expand Down

0 comments on commit 7ac0d6c

Please sign in to comment.