Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another case of Float #19

Closed
idarlington opened this issue Jun 17, 2016 · 12 comments
Closed

Another case of Float #19

idarlington opened this issue Jun 17, 2016 · 12 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@idarlington
Copy link
Contributor

idarlington commented Jun 17, 2016

Hi, so I noticed another case of the exercise expecting a Float instead of a Double

Tuple Section

def assignVariablesTuples(res0: String, res1: Int, res2: Float) {
    val student = ("Sean Rogers", 21, 3.5)
    val (name, age, gpa) = student

    name should be(res0)
    age should be(res1)
    gpa should be(res2)
  }

If the expected user input should be Floats, then it should probably be specified in the readme or in each exercise.

@raulraja
Copy link
Member

No point for Floats, it's an oversight from we when ported the original Koans over. PRs welcome!

@raulraja raulraja added enhancement New feature or request help wanted Extra attention is needed labels Jun 24, 2016
@idarlington
Copy link
Contributor Author

Ok @raulraja I would work on it.

@idarlington
Copy link
Contributor Author

Hi @raulraja what repository is this dependency available in :

addSbtPlugin("org.scala-exercises" % "sbt-exercise" % "0.0.0-SNAPSHOT", "0.13", "2.10")

Do I have to publish it locally ?

@raulraja
Copy link
Member

It's in the scala-exercises repo under a submodule. There is a script to
publish all dependencies locally

On Fri, Jun 24, 2016, 3:46 PM Ikenna Darlington Ogbajie <
notifications@github.com> wrote:

Hi @raulraja https://github.com/raulraja what repository is this
dependency available in :

addSbtPlugin("org.scala-exercises" % "sbt-exercise" % "0.0.0-SNAPSHOT", "0.13", "2.10")

Do I have to publish it locally ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAb4XDUvRQs4XCgIiJvTFxyF1Tyb3ZR2ks5qO9-7gaJpZM4I4sh7
.

@idarlington
Copy link
Contributor Author

@raulraja you mean this repo ?

I can't seem to find the script that publishes dependencies.

@raulraja
Copy link
Member

It's a sbt command alias sbt publishAll https://github.com/scala-exercises/scala-exercises/blob/master/build.sbt#L294

@idarlington
Copy link
Contributor Author

idarlington commented Jun 24, 2016

Ok, I am aware of that,I thought you meant a bash script.
Thanks.

@raulraja
Copy link
Member

Yes it's the same repo as the site that contains the compiler and sbt
plugin

On Fri, Jun 24, 2016, 5:01 PM Ikenna Darlington Ogbajie <
notifications@github.com> wrote:

Ok, I thought you meant a bash script.

So for the other question is it the repo i linked to?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAb4XA2f9VlgOkNJ06co5w9PThCoI5Dkks5qO_FdgaJpZM4I4sh7
.

@idarlington
Copy link
Contributor Author

idarlington commented Jun 24, 2016

Hi @raulraja, I get these errors when compiling, I think it has to do with Github Authentication

[info] Fetching contributions for repository scala-exercises/exercises-stdlib file /src/main/scala/stdlib/Asserts.scala
github4s.GithubResponses$UnexpectedException: Failed invoking get with status : 403, body : 
 {"message":"API rate limit exceeded for 197.242.97.177. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://developer.github.com/v3/#rate-limiting"}
[error] (compile-generated-exercises:generateExercises) github4s.GithubResponses$UnexpectedException: Failed invoking get with status : 403, body : 
[error]  {"message":"API rate limit exceeded for 197.242.97.177. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://developer.github.com/v3/#rate-limiting"}

@ghost
Copy link

ghost commented Jun 27, 2016

@idarlington as mentioned in the README of scala-exercises, you'll want to set the GITHUB_TOKEN environment variable for not hitting the GitHub API's rate limit. You can obtain a token here.

@raulraja
Copy link
Member

@idarlington feel free to reopen this if the issue continues after using your ownGITHUB_TOKEN

@idarlington
Copy link
Contributor Author

@raulraja no problem, I resolved this with @rafaparadela in the gitter channel. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants