Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses Integer values when creating BigDecimal values to avoid the decimal point when calling toString #66

Merged
merged 1 commit into from
Dec 26, 2016
Merged

Uses Integer values when creating BigDecimal values to avoid the decimal point when calling toString #66

merged 1 commit into from
Dec 26, 2016

Conversation

jsuarezb
Copy link
Contributor

@jsuarezb jsuarezb commented Dec 4, 2016

Seeing BigDecimal(34.00).toString() makes the programmer guess if the answer is 34, 34.0 or 34.00. Maybe it's simpler to have them all as Integer instead of Double and avoid the confusion.

juanpedromoreno
juanpedromoreno approved these changes Dec 26, 2016
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your time!

@juanpedromoreno juanpedromoreno merged commit d2d632a into scala-exercises:master Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsuarezb @juanpedromoreno