-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trailing comma support - "Expected identifier, but got Token(RPAREN,),xxx,)) #260
Comments
For everyone who thumbs up'd this issue the companion PR won't get merged until there's some test coverage that verifies trailing commas work as expected (and don't break existing tests). A simple test implementation might look like this. |
I made a parser spec that the PR fails on -- working on a fix that supports http://docs.scala-lang.org/sips/completed/trailing-commas.html TL;DR: https://github.com/c-dante/scalariform/tree/260-trailing-comma Edit: Edit2: Seq(1,
) However this is not: Which the current lexer setup doesn't allow checking for Edit3: |
fixed in #262 |
linked issue with reproducer scalastyle/scalastyle#276
even simpler example of valid scala 2.12 code
is not parsed correctly
The text was updated successfully, but these errors were encountered: