Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalariform should not fail on '_' in numeric literals #293

Open
diversit opened this issue Jun 7, 2022 · 0 comments
Open

Scalariform should not fail on '_' in numeric literals #293

diversit opened this issue Jun 7, 2022 · 0 comments

Comments

@diversit
Copy link

diversit commented Jun 7, 2022

We change to use SonarScala plugin in SonarQube to scan our Scala code.
However, the scan fails on numeric literals like 100_000L.

This is caused by the function checkNoLetter in ScalaOnlyLexer L509.

Could the checkNoLetter function be changed to not fail on _ characters in a number since this is valid Scala code?

Error

scalariform.lexer.ScalaLexerException: Invalid literal number: _

Expected
Scalariform should not fail on literal numbers with _ like 150_100L.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diversit