Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drivers are not quit() after running tests #124

Closed
vasilmkd opened this issue Aug 3, 2021 · 1 comment
Closed

Drivers are not quit() after running tests #124

vasilmkd opened this issue Aug 3, 2021 · 1 comment
Assignees
@gzm0
Labels
bug

Comments

@vasilmkd
Copy link

vasilmkd commented Aug 3, 2021

This can be seen either locally, with driver (e.g. geckodriver and chromedriver) processes continuing to run even after the browser windows have exited, or in the GitHub Actions, by examining the very tail of the logs (here's a paste):

2021-08-02T10:33:09.1641530Z Cleaning up orphan processes
2021-08-02T10:33:09.2084581Z Terminate orphan process: pid (2078) (geckodriver)
2021-08-02T10:33:09.2113913Z Terminate orphan process: pid (2334) (geckodriver)
2021-08-02T10:33:09.2140292Z Terminate orphan process: pid (2498) (geckodriver)
2021-08-02T10:33:09.2166546Z Terminate orphan process: pid (2660) (geckodriver)
2021-08-02T10:33:09.2192362Z Terminate orphan process: pid (2853) (geckodriver)
2021-08-02T10:33:09.2218550Z Terminate orphan process: pid (3031) (geckodriver)
2021-08-02T10:33:09.2244564Z Terminate orphan process: pid (3243) (geckodriver)
2021-08-02T10:33:09.2270772Z Terminate orphan process: pid (3429) (geckodriver)
2021-08-02T10:33:09.2296840Z Terminate orphan process: pid (3611) (geckodriver)
2021-08-02T10:33:09.2322690Z Terminate orphan process: pid (3801) (geckodriver)
2021-08-02T10:33:09.2348695Z Terminate orphan process: pid (3981) (geckodriver)
2021-08-02T10:33:09.2374719Z Terminate orphan process: pid (4184) (geckodriver)
2021-08-02T10:33:09.2401030Z Terminate orphan process: pid (4378) (geckodriver)
2021-08-02T10:33:09.2427075Z Terminate orphan process: pid (4568) (geckodriver)
2021-08-02T10:33:09.2453025Z Terminate orphan process: pid (4771) (geckodriver)
2021-08-02T10:33:09.2479183Z Terminate orphan process: pid (4944) (geckodriver)
2021-08-02T10:33:09.2505164Z Terminate orphan process: pid (5141) (geckodriver)
2021-08-02T10:33:09.2551246Z Terminate orphan process: pid (5298) (geckodriver)
2021-08-02T10:33:09.2577794Z Terminate orphan process: pid (5499) (geckodriver)
2021-08-02T10:33:09.2604036Z Terminate orphan process: pid (5670) (geckodriver)
2021-08-02T10:33:09.2630240Z Terminate orphan process: pid (5864) (geckodriver)
2021-08-02T10:33:09.2656184Z Terminate orphan process: pid (6035) (geckodriver)
2021-08-02T10:33:09.2682025Z Terminate orphan process: pid (6221) (geckodriver)
2021-08-02T10:33:09.2708050Z Terminate orphan process: pid (6425) (geckodriver)
2021-08-02T10:33:09.2733988Z Terminate orphan process: pid (6614) (geckodriver)
2021-08-02T10:33:09.2760610Z Terminate orphan process: pid (6795) (geckodriver)
2021-08-02T10:33:09.2787065Z Terminate orphan process: pid (6995) (geckodriver)
2021-08-02T10:33:09.2813000Z Terminate orphan process: pid (7189) (geckodriver)
2021-08-02T10:33:09.2839119Z Terminate orphan process: pid (7368) (geckodriver)
2021-08-02T10:33:09.2865359Z Terminate orphan process: pid (7566) (geckodriver)
2021-08-02T10:33:09.2891432Z Terminate orphan process: pid (7733) (geckodriver)
2021-08-02T10:33:09.2917522Z Terminate orphan process: pid (7945) (geckodriver)
2021-08-02T10:33:09.2943812Z Terminate orphan process: pid (8120) (geckodriver)
2021-08-02T10:33:09.2969782Z Terminate orphan process: pid (8319) (geckodriver)
2021-08-02T10:33:09.2995735Z Terminate orphan process: pid (8500) (geckodriver)
2021-08-02T10:33:09.3021760Z Terminate orphan process: pid (8704) (geckodriver)
2021-08-02T10:33:09.3047662Z Terminate orphan process: pid (8881) (geckodriver)
2021-08-02T10:33:09.3073755Z Terminate orphan process: pid (9087) (geckodriver)
2021-08-02T10:33:09.3099847Z Terminate orphan process: pid (9278) (geckodriver)
2021-08-02T10:33:09.3126450Z Terminate orphan process: pid (9631) (geckodriver)
2021-08-02T10:33:09.3152334Z Terminate orphan process: pid (9783) (geckodriver)
2021-08-02T10:33:09.3178828Z Terminate orphan process: pid (10013) (geckodriver)
2021-08-02T10:33:09.3205272Z Terminate orphan process: pid (10275) (geckodriver)
2021-08-02T10:33:09.3243761Z Terminate orphan process: pid (10282) (firefox)
2021-08-02T10:33:09.3286058Z Terminate orphan process: pid (10321) (Web Content)
2021-08-02T10:33:09.3322258Z Terminate orphan process: pid (10340) (WebExtensions)
2021-08-02T10:33:09.3358068Z Terminate orphan process: pid (10431) (file:// Content)
2021-08-02T10:33:09.3394411Z Terminate orphan process: pid (10453) (Web Content)
2021-08-02T10:33:09.3422298Z Terminate orphan process: pid (10466) (geckodriver)
2021-08-02T10:33:09.3450441Z Terminate orphan process: pid (10667) (geckodriver)
2021-08-02T10:33:09.3504158Z Terminate orphan process: pid (10675) (firefox)
2021-08-02T10:33:09.3544249Z Terminate orphan process: pid (10733) (Web Content)
2021-08-02T10:33:09.3579868Z Terminate orphan process: pid (10752) (WebExtensions)
2021-08-02T10:33:09.3615575Z Terminate orphan process: pid (10808) (Web Content)
2021-08-02T10:33:09.3651659Z Terminate orphan process: pid (10827) (file:// Content)
2021-08-02T10:33:09.3690570Z Terminate orphan process: pid (10857) (python3)
2021-08-02T10:33:09.3720813Z Terminate orphan process: pid (11018) (geckodriver)
2021-08-02T10:33:09.3747052Z Terminate orphan process: pid (11198) (geckodriver)
2021-08-02T10:33:09.3784312Z Terminate orphan process: pid (11421) (geckodriver)
2021-08-02T10:33:09.3814662Z Terminate orphan process: pid (11428) (firefox)
2021-08-02T10:33:09.3855762Z Terminate orphan process: pid (11469) (Web Content)
2021-08-02T10:33:09.3891491Z Terminate orphan process: pid (11485) (WebExtensions)
2021-08-02T10:33:09.3928331Z Terminate orphan process: pid (11557) (Web Content)
2021-08-02T10:33:09.3955191Z Terminate orphan process: pid (11580) (geckodriver)
2021-08-02T10:33:09.4009287Z Terminate orphan process: pid (11587) (firefox)
2021-08-02T10:33:09.4050922Z Terminate orphan process: pid (11632) (WebExtensions)
2021-08-02T10:33:09.4088075Z Terminate orphan process: pid (11652) (Web Content)
2021-08-02T10:33:09.4138035Z Terminate orphan process: pid (11733) (Web Content)

2021-08-02T10:32:07.6793482Z Cleaning up orphan processes
2021-08-02T10:32:07.7274109Z Terminate orphan process: pid (2067) (chromedriver)
2021-08-02T10:32:07.7309909Z Terminate orphan process: pid (2152) (chromedriver)
2021-08-02T10:32:07.7336872Z Terminate orphan process: pid (2235) (chromedriver)
2021-08-02T10:32:07.7366006Z Terminate orphan process: pid (2314) (chromedriver)
2021-08-02T10:32:07.7398513Z Terminate orphan process: pid (2398) (chromedriver)
2021-08-02T10:32:07.7428649Z Terminate orphan process: pid (2485) (chromedriver)
2021-08-02T10:32:07.7455734Z Terminate orphan process: pid (2570) (chromedriver)
2021-08-02T10:32:07.7487426Z Terminate orphan process: pid (2652) (chromedriver)
2021-08-02T10:32:07.7518311Z Terminate orphan process: pid (2733) (chromedriver)
2021-08-02T10:32:07.7543305Z Terminate orphan process: pid (2814) (chromedriver)
2021-08-02T10:32:07.7577317Z Terminate orphan process: pid (2898) (chromedriver)
2021-08-02T10:32:07.7617644Z Terminate orphan process: pid (2979) (chromedriver)
2021-08-02T10:32:07.7655903Z Terminate orphan process: pid (3062) (chromedriver)
2021-08-02T10:32:07.7687066Z Terminate orphan process: pid (3143) (chromedriver)
2021-08-02T10:32:07.7714106Z Terminate orphan process: pid (3224) (chromedriver)
2021-08-02T10:32:07.7740870Z Terminate orphan process: pid (3307) (chromedriver)
2021-08-02T10:32:07.7768947Z Terminate orphan process: pid (3393) (chromedriver)
2021-08-02T10:32:07.7801201Z Terminate orphan process: pid (3472) (chromedriver)
2021-08-02T10:32:07.7836780Z Terminate orphan process: pid (3555) (chromedriver)
2021-08-02T10:32:07.7868597Z Terminate orphan process: pid (3637) (chromedriver)
2021-08-02T10:32:07.7899911Z Terminate orphan process: pid (3718) (chromedriver)
2021-08-02T10:32:07.7930059Z Terminate orphan process: pid (3800) (chromedriver)
2021-08-02T10:32:07.7962080Z Terminate orphan process: pid (3887) (chromedriver)
2021-08-02T10:32:07.8046295Z Terminate orphan process: pid (3975) (chromedriver)
2021-08-02T10:32:07.8076287Z Terminate orphan process: pid (4066) (chromedriver)
2021-08-02T10:32:07.8105672Z Terminate orphan process: pid (4152) (chromedriver)
2021-08-02T10:32:07.8135650Z Terminate orphan process: pid (4234) (chromedriver)
2021-08-02T10:32:07.8165753Z Terminate orphan process: pid (4319) (chromedriver)
2021-08-02T10:32:07.8195611Z Terminate orphan process: pid (4401) (chromedriver)
2021-08-02T10:32:07.8226794Z Terminate orphan process: pid (4482) (chromedriver)
2021-08-02T10:32:07.8258863Z Terminate orphan process: pid (4566) (chromedriver)
2021-08-02T10:32:07.8288064Z Terminate orphan process: pid (4647) (chromedriver)
2021-08-02T10:32:07.8315353Z Terminate orphan process: pid (4727) (chromedriver)
2021-08-02T10:32:07.8344185Z Terminate orphan process: pid (4807) (chromedriver)
2021-08-02T10:32:07.8373960Z Terminate orphan process: pid (4891) (chromedriver)
2021-08-02T10:32:07.8404664Z Terminate orphan process: pid (4976) (chromedriver)
2021-08-02T10:32:07.8437005Z Terminate orphan process: pid (5056) (chromedriver)
2021-08-02T10:32:07.8465334Z Terminate orphan process: pid (5142) (chromedriver)
2021-08-02T10:32:07.8496962Z Terminate orphan process: pid (5226) (chromedriver)
2021-08-02T10:32:07.8525835Z Terminate orphan process: pid (5466) (chromedriver)
2021-08-02T10:32:07.8553729Z Terminate orphan process: pid (5551) (chromedriver)
2021-08-02T10:32:07.8583288Z Terminate orphan process: pid (5632) (chromedriver)
2021-08-02T10:32:07.8613109Z Terminate orphan process: pid (5751) (chromedriver)
2021-08-02T10:32:07.8642917Z Terminate orphan process: pid (5835) (chromedriver)
2021-08-02T10:32:07.8675556Z Terminate orphan process: pid (5918) (chromedriver)
2021-08-02T10:32:07.8702696Z Terminate orphan process: pid (6005) (python3)
2021-08-02T10:32:07.8733242Z Terminate orphan process: pid (6157) (chromedriver)
2021-08-02T10:32:07.8761822Z Terminate orphan process: pid (6249) (chromedriver)
2021-08-02T10:32:07.8795800Z Terminate orphan process: pid (6349) (chromedriver)
2021-08-02T10:32:07.8830301Z Terminate orphan process: pid (6360) (chrome)
2021-08-02T10:32:07.8864102Z Terminate orphan process: pid (6365) (cat)
2021-08-02T10:32:07.8894534Z Terminate orphan process: pid (6366) (cat)
2021-08-02T10:32:07.8984793Z Terminate orphan process: pid (6440) (chromedriver)
2021-08-02T10:32:07.9019158Z Terminate orphan process: pid (6449) (chrome)
2021-08-02T10:32:07.9052645Z Terminate orphan process: pid (6454) (cat)
2021-08-02T10:32:07.9085327Z Terminate orphan process: pid (6455) (cat)
@vasilmkd vasilmkd changed the title Drivers are not quit after running tests Drivers are not quit() after running tests Aug 3, 2021
@gzm0 gzm0 self-assigned this Aug 4, 2021
@gzm0 gzm0 added the bug label Aug 4, 2021
@gzm0
Copy link
Contributor

gzm0 commented Aug 4, 2021

Hah, nice catch :) Thanks for the report. Seems this is basically because I do not understand the difference between close and quit in Selenium. This should be quit:

scala-js-env-selenium/seleniumJSEnv/src/main/scala/org/scalajs/jsenv/selenium/SeleniumRun.scala

Line 165 in 5372e7f

if (!config.keepAlive) d.close()

gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Aug 4, 2021
@gzm0
Fix scala-js#124: Call quit not close on WebDriver for cleanup
08ae591
@sjrd sjrd closed this as completed in 0b99685 Aug 8, 2021
sjrd added a commit that referenced this issue Aug 8, 2021
@sjrd
Merge pull request #125 from gzm0/quit-not-close
7e51c99 
Fix #124: Call quit not close on WebDriver for cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gzm0 @vasilmkd