Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W3C WebDriver spec lacks log interface; test errors in latest geckodriver #64

Closed
godenji opened this issue May 15, 2017 · 1 comment
Closed

W3C WebDriver spec lacks log interface; test errors in latest geckodriver #64

godenji opened this issue May 15, 2017 · 1 comment
Assignees
@gzm0
Labels
bug
Milestone
v0.2.0

Comments

@godenji
Copy link

godenji commented May 15, 2017

Geckodriver maintainer's response.

Only solution for now seems to be @Ignoreing affected tests (timeoutSingleArgTest, utf8Test, and allowScriptTags) in SeleniumJSEnvFirefoxTest as they depend on hasOutput method, which attempts to reference non-existent log implementation.
godenji added a commit to godenji/scala-js-env-selenium that referenced this issue May 15, 2017
@godenji
Upgrade Deps
2290714 
Notably upgrading to Selenium 3.4.0 along with corresponding Chrome and Firefox drivers.

Latest version of Chrome driver introduced some changes to their API which this PR addresses in `Chrome.scala`.

Latest version of Firefox driver (geckodriver) adheres more closely to W3C WebDriver spec, which requires us to @ignore a couple of tests that rely on non-existent logger implementation (see issue scala-js#64). Additionally geckodriver no longer allows negative values a la `...scriptTimeout(-1, TimeUnit.SECONDS)` (see issue scala-js#65); fallback to default 30 second timeout as workaround.

Misc. minor fixes of deprecation warnings with upgrade to scala 2.12.2
@gzm0 gzm0 added the bug label Jul 27, 2017
@gzm0 gzm0 self-assigned this Jul 27, 2017
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Make error handling driver independent
cb0d359 
This fixes scala-js#60, scala-js#61 and scala-js#64.
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Make error handling driver independent
e4281af 
This fixes scala-js#60, scala-js#61 and scala-js#64.
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Make error handling driver independent
bed756f 
This fixes scala-js#60, scala-js#61 and scala-js#64.
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Make error handling driver independent
005c3d2 
This fixes scala-js#60, scala-js#61 and scala-js#64.
@gzm0
Copy link
Contributor

gzm0 commented Jul 27, 2017

Fixed in 005c3d2

@gzm0 gzm0 closed this as completed Jul 27, 2017
@gzm0 gzm0 modified the milestone: v0.2.0 Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
bug
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@godenji @gzm0