Fix #105: Re-enable largeMessageTest #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like chrome really needs to be at 89 for this (current version on travis seems to be 88). |
gzm0
force-pushed
the
re-enable-large-message-test
branch
from
6e9c748 to
0886d6e
Compare
gzm0
force-pushed
the
re-enable-large-message-test
branch
from
0886d6e to
3e4e4de
Compare
|
Chrome 89 seems to be included in the virtual-environment release of March 9: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210309.1 |
The upstream issue [1] has been fixed in Chrome 89, which has just hit the GitHub Actions virtual environment [2]. [1]: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3672 [2]: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210309.1
gzm0
force-pushed
the
re-enable-large-message-test
branch
from
3e4e4de to
47ac5f0
Compare
gzm0
changed the title
sjrd
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.