Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use scalafixAll #1523

Merged
merged 1 commit into from
Jul 3, 2020
Merged

use scalafixAll #1523

merged 1 commit into from
Jul 3, 2020

Conversation

bjaglin
Copy link
Contributor

@bjaglin bjaglin commented Jul 3, 2020 •
edited
Loading

Use scalacenter/sbt-scalafix#126, released in sbt-scalafix 0.9.18.

This slightly improves runtime as migrations can be run in parallel for Compile and Test.

Note that this will NOT run migrations on IntegrationTest or any other custom configuration, as Scalafix needs to be enabled explicitly on them.

@bjaglin bjaglin changed the title use scalafixAll to run migrations for all configurations use scalafixAll Jul 3, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020 •
edited
Loading

Codecov Report

Merging #1523 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   70.11%   70.07%   -0.04%     
==========================================
  Files         112      112              
  Lines        1780     1778       -2     
  Branches       50       48       -2     
==========================================
- Hits         1248     1246       -2     
  Misses        532      532
Impacted Files Coverage Δ
...a/org/scalasteward/core/buildtool/sbt/SbtAlg.scala 93.33% <ø> (-0.22%) ⬇️
.../org/scalasteward/core/buildtool/sbt/command.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b7815...5b68eab. Read the comment docs.

@github-brice-jaglin
use scalafixAll from sbt-scalafix 0.9.18
5b68eab 
This slightly improves runtime as migrations can be run in parallel
for Compile and Test.

Note that this will NOT run migrations on IntegrationTest or any other
custom configuration, as Scalafix needs to be enabled explicitly on
them.

https://github.com/scalacenter/scalafix/blob/v0.9.18/docs/users/installation.md#integration-tests
@bjaglin
Copy link
Contributor Author

bjaglin commented Jul 3, 2020 •
edited
Loading

Note that this will NOT run migrations on IntegrationTest or any other custom configuration, as Scalafix needs to be enabled explicitly on them.

Maybe slightly off topic, but I wonder if there is a demand for that in the context of scala-steward? If so, it could be interesting to provide a scalafixEnableAll command.

@bjaglin bjaglin marked this pull request as ready for review July 3, 2020 20:12
fthomas
fthomas approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks @bjaglin!

@fthomas fthomas merged commit 08fea51 into scala-steward-org:master Jul 3, 2020
@fthomas fthomas added this to the 0.7.0 milestone Jul 3, 2020
@fthomas fthomas added the enhancement New feature or request label Jul 3, 2020
@fthomas
Copy link
Member

fthomas commented Jul 3, 2020 •
edited
Loading

Maybe slightly off topic, but I wonder if there is a demand for that in the context of scala-steward? If so, it could be interesting to provide a scalafixEnableAll command.

Nobody has asked for this yet or complained about it but I guess it makes sense to have something like scalafixEnableAll so that Scala Steward migrates all sources in a project and not only the sources of the Compile and Test configurations.

@bjaglin bjaglin mentioned this pull request Jul 3, 2020
Closed
@bjaglin
Copy link
Contributor Author

bjaglin commented Jul 3, 2020 •
edited
Loading

For the record, following up in scalacenter/scalafix#1197

@bjaglin bjaglin mentioned this pull request Sep 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fthomas fthomas fthomas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bjaglin @fthomas @github-brice-jaglin