Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pagination in installation/repositories and app/installations #1777

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1777 (6ce0066) into master (a60fe5f) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
- Coverage   74.68%   74.10%   -0.58%     
==========================================
  Files         123      123              
  Lines        2050     2066      +16     
  Branches       51       49       -2     
==========================================
  Hits         1531     1531              
- Misses        519      535      +16     
Impacted Files Coverage Δ
...la/org/scalasteward/core/util/HttpJsonClient.scala 46.15% <0.00%> (-39.57%) ⬇️
...scalasteward/core/vcs/github/GitHubAppApiAlg.scala 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60fe5f...6ce0066. Read the comment docs.

@xuwei-k xuwei-k mentioned this pull request Dec 1, 2020
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I guess the next evolution of the all method would be to return a Stream[F, A] instead of a F[List[A]].

@fthomas fthomas merged commit cdb6299 into scala-steward-org:master Dec 2, 2020
@fthomas fthomas added the enhancement New feature or request label Dec 2, 2020
@fthomas fthomas added this to the 0.9.0 milestone Dec 2, 2020
@xuwei-k xuwei-k deleted the pagination-github-apps branch November 13, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants