Switched default docker base image from openjdk8 to adoptopenjdk11 #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but the |
froth
force-pushed
the
docker-adoptopenjdk11
branch
from
fb6cd59 to
57939d4
Compare
done |
Codecov Report
@@ Coverage Diff @@
## master #2167 +/- ##
=======================================
Coverage 78.16% 78.16%
=======================================
Files 131 131
Lines 2249 2249
Branches 57 57
=======================================
Hits 1758 1758
Misses 491 491 Continue to review full report at Codecov.
|
fthomas
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2156
Unfortunately there exists no openjdk11-alpine image from the openjdk organisation (docker-library/openjdk#235 (comment) docker-library/openjdk#313).
Therefore I decided to switch to the alpine variant of adoptopenjdk. Another approach would be to switch to something like openjdk/11-jdk-slim. My reasoning behind doing it this way was to keep the operation system constant (and good experience with adoptopenjdk). If you prefer the other way around: I am happy to change the PR.