Fix #247 ensure binary compatibility from now #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have force-pushed just to update some comments |
|
@lrytz I haven't looked at the fnGen stuff before. but this certainly looks plausible, and we should get a release out before much longer, to correct the bincompat breakage. any objection to just merging this? |
gcf-merge-on-green bot
referenced
this pull request
in googleapis/java-pubsublite-spark
Nov 3, 2021
…1 to v1.0.2 (#295) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.scala-lang.modules:scala-java8-compat_2.11](http://www.scala-lang.org/) ([source](https://github.com/scala/scala-java8-compat)) | `1.0.1` -> `1.0.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>scala/scala-java8-compat</summary> ### [`v1.0.2`](https://github.com/scala/scala-java8-compat/releases/v1.0.2) [Compare Source](https://github.com/scala/scala-java8-compat/compare/v1.0.1...v1.0.2) #### What's Changed - Fix [#​247](https://github.com/scala/scala-java8-compat/issues/247) ensure binary compatibility from now by [@​ohze](https://github.com/ohze) in [https://github.com/scala/scala-java8-compat/pull/248](https://github.com/scala/scala-java8-compat/pull/248) #### New Contributors - [@​ohze](https://github.com/ohze) made their first contribution in [https://github.com/scala/scala-java8-compat/pull/248](https://github.com/scala/scala-java8-compat/pull/248) **Full Changelog**: scala/scala-java8-compat@v1.0.1...v1.0.2 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsublite-spark).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
FunctionConvertersis generated by an internalfnGensbt project that use scala-compiler & scala-reflect to generate converter for all interfaces injava.util.functionpackage.Problem
fnGenis not reliable. It produce different code on different run [1]In #211, @SethTisue have to add some
ProblemFilters.exclude.But, as describing in #247, the mima Problem should not be filtered out because it will cause real binary incompatible error in runtime.
Solution by this PR
fnGen: Don't use scala-compiler & scala-reflectThe generated code by the new
fnGenimplementation is exactly same as the generated code by the oldfnGenon my machine. (somehow, the oldfnGenis reliable in my machine :D)You can and should verify that in your machine too.
[1]
sbt sourceson CI (on my fork) and check the generated code, I found that the output is different in some CI jobs / runs.FunctionConvertersnot only between versions but also in the same version with different scala cross build (ex.._2.12-1.0.1.jarvs.._2.12-1.0.1.jar). See this CI job that run mima against all released version from 0.9.1 and only v0.9.1 for scala 2.12 is mima check passed.