Drop support for Scala 2.11.x #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, I was just coming to the repo to say the same thing. I'm in favor. If some really critical bugfix ends up being needed on 2.11, we could always do it from a branch — especially if a volunteer who cares about 2.11 is willing to do the work. |
|
heh, over at scala/scala-xml#646, Philippus pointed out that scala-xml actually dropped 2.11 support several years ago. apparently nobody cared, or not enough to complain anyway. so that's encouraging that maybe nobody will care if we do the same here |
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Jul 4, 2023
### What changes were proposed in this pull request? This pr aims to upgrade `scala-parser-combinators` from 2.2.0 to 2.3.0 ### Why are the changes needed? The new version [dropped support for Scala 2.11](scala/scala-parser-combinators#504) and bring a bug fix: - scala/scala-parser-combinators#507 The full release notes as follows: - https://github.com/scala/scala-parser-combinators/releases/tag/v2.3.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions Closes apache#41848 from LuciferYang/scala-parser-combinators-23. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to drop support for scala 2.11.x. Then we can keep up with scala-js and scala-native updates.
See #502 and #503.