-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for Unicode supplementary characters in identifiers and string interpolation #9805
Conversation
3a640d7
to
53fc7ce
Compare
0f553cb
to
d59d371
Compare
While looking at this, I had to relearn scala/vscode-scala-syntax#222 (comment) in fact the last thing in my repl history is:
Conversely, the obsolete test code was going to test |
d59d371
to
1fe3000
Compare
Precedence uses codepoint when probing lead char. Scanner accepts supplementary chars in more places, such as op_Supple, Supple"interp", s"$Supple".
1fe3000
to
d97a0a3
Compare
I promise I'll get around to this this week, sorry for taking so long. |
@martijnhoekstra still interested in pursuing this? |
They have really long vacations over there. In America, they talk about the Halloween to New Year's period, but there it's All Hallow's to Summer Solstice. |
@unkarjedy you opened all four of the original tickets; would you be interested in reviewing this? |
Also thanks @martijnhoekstra for previous help. As the author, I am off the hook for review, which would require me to understand the delta. I dread the forward port, if necessary. |
I was about to say thanks @martijnhoekstra but I see I just said that. Now I have to review how this PR compares with what is on dotty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@som-snytt shall we go ahead and hit "merge"? can't quite tell if you're done. |
I'm not sure if @lrytz is done. Edit: I'm not sure if lrytz will say I'm not done. |
Happy to have it merged, my comment was just a nudge to see if you have a better idea. |
Not only am I out of ideas, I have no memory of what this code does. If I have an idea when forward porting to Scala 3, I'll be sure to backport it. |
Precedence uses codepoint when probing lead char.
Scanner accepts supplementary chars in more places,
such as op_Supple, 'Supple'.
Fixes scala/bug#12482
Fixes scala/bug#12484
Fixes scala/bug#12485
Fixes scala/bug#12486