ordinal: drop unchecked with sealed abstract skips #13414
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ordinal
method, drop the use of@unchecked
by skipping childrenthat are sealed traits or sealed abstract classes and don't have any
anonymous subclasses.
The
@unchecked
I added in ee5a82f. In aPR to do specifically with reachability I started seeing similar warnings in
ordinal
(this was before adding@unchecked
was merged) so I'm hopingwith this patch to avoid the false positives properly.