Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Normalize after applyIfParameterized in superType #13615

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

anatoliykmetyuk
Copy link
Contributor

Backports #13253

@anatoliykmetyuk
Copy link
Contributor Author

CI Fail
2021-09-27T15:18:45.1770665Z   reduce type  B match ... while compiling tests/neg-custom-args/allow-deep-subtypes/9849.scala
2021-09-27T15:18:45.2041304Z Fatal compiler crash when compiling: tests/neg-custom-args/allow-deep-subtypes/9849.scala:
2021-09-27T15:18:45.2042862Z 
2021-09-27T15:18:45.2044638Z dotty.tools.dotc.core.Types$TypeMap.mapOver(Types.scala:5412)
2021-09-27T15:18:45.2047186Z dotty.tools.dotc.core.Substituters$.substParams(Substituters.scala:161)
2021-09-27T15:18:45.2050243Z dotty.tools.dotc.core.Substituters$SubstParamsMap.apply(Substituters.scala:197)
2021-09-27T15:18:45.2053568Z dotty.tools.dotc.core.Substituters$SubstParamsMap.apply(Substituters.scala:197)
2021-09-27T15:18:45.2056681Z scala.collection.immutable.List.mapConserve(List.scala:472)
2021-09-27T15:18:45.2059464Z dotty.tools.dotc.core.Types$TypeMap.mapOverLambda(Types.scala:5378)
2021-09-27T15:18:45.2061874Z dotty.tools.dotc.core.Types$TypeMap.mapOver(Types.scala:5405)
2021-09-27T15:18:45.2064446Z dotty.tools.dotc.core.Substituters$.substParams(Substituters.scala:161)
2021-09-27T15:18:45.2067452Z dotty.tools.dotc.core.Substituters$SubstParamsMap.apply(Substituters.scala:197)
2021-09-27T15:18:45.2070643Z dotty.tools.dotc.core.Substituters$SubstParamsMap.apply(Substituters.scala:197)
2021-09-27T15:18:45.2073733Z scala.collection.immutable.List.mapConserve(List.scala:472)
2021-09-27T15:18:45.2076376Z dotty.tools.dotc.core.Types$TypeMap.mapOver(Types.scala:5471)
2021-09-27T15:18:45.2078943Z dotty.tools.dotc.core.Substituters$.substParams(Substituters.scala:161)
2021-09-27T15:18:45.2081474Z dotty.tools.dotc.core.Types$Type.substParams(Types.scala:1765)
2021-09-27T15:18:45.2083906Z dotty.tools.dotc.core.Types$LambdaType.instantiate(Types.scala:3428)
2021-09-27T15:18:45.2086396Z dotty.tools.dotc.core.Types$LambdaType.instantiate$(Types.scala:3389)
2021-09-27T15:18:45.2088763Z dotty.tools.dotc.core.Types$HKLambda.instantiate(Types.scala:3462)
2021-09-27T15:18:45.2091263Z dotty.tools.dotc.core.TypeApplications$.tryReduce$1(TypeApplications.scala:335)
2021-09-27T15:18:45.2094340Z dotty.tools.dotc.core.TypeApplications$.appliedTo$extension(TypeApplications.scala:354)
2021-09-27T15:18:45.2097762Z dotty.tools.dotc.core.TypeApplications$.applyIfParameterized$extension(TypeApplications.scala:380)
2021-09-27T15:18:45.2100708Z dotty.tools.dotc.core.Types$AppliedType.superType(Types.scala:4116)
2021-09-27T15:18:45.2103721Z dotty.tools.dotc.core.TypeComparer.provablyDisjoint(TypeComparer.scala:2651)
2021-09-27T15:18:45.2107255Z dotty.tools.dotc.core.TypeComparer.provablyDisjoint(TypeComparer.scala:2647)
2021-09-27T15:18:45.2110974Z dotty.tools.dotc.core.TypeComparer.provablyDisjoint(TypeComparer.scala:2647)
2021-09-27T15:18:45.2114350Z dotty.tools.dotc.core.TrackingTypeComparer.matchCase$1(TypeComparer.scala:2913)
2021-09-27T15:18:45.2117970Z dotty.tools.dotc.core.TrackingTypeComparer.recur$1(TypeComparer.scala:2923)
2021-09-27T15:18:45.2121523Z dotty.tools.dotc.core.TrackingTypeComparer.op$proxy68$1(TypeComparer.scala:2953)
2021-09-27T15:18:45.2125097Z dotty.tools.dotc.core.TrackingTypeComparer.matchCases(TypeComparer.scala:2954)
2021-09-27T15:18:45.2128192Z dotty.tools.dotc.core.Types$MatchType.liftedTree1$2(Types.scala:4711)
2021-09-27T15:18:45.2130475Z dotty.tools.dotc.core.Types$MatchType.matchCases$1(Types.scala:4716)
2021-09-27T15:18:45.2133532Z dotty.tools.dotc.core.Types$MatchType.reduced$$anonfun$1(Types.scala:4720)
2021-09-27T15:18:45.2136443Z dotty.tools.dotc.core.TypeComparer.inSubComparer(TypeComparer.scala:2663)
2021-09-27T15:18:45.2140047Z dotty.tools.dotc.core.TypeComparer.tracked(TypeComparer.scala:2673)
2021-09-27T15:18:45.2142836Z dotty.tools.dotc.core.TypeComparer$.tracked(TypeComparer.scala:2826)
2021-09-27T15:18:45.2145239Z dotty.tools.dotc.core.Types$MatchType.reduced(Types.scala:4720)
2021-09-27T15:18:45.2147545Z dotty.tools.dotc.core.Types$MatchType.tryNormalize(Types.scala:4669)
2021-09-27T15:18:45.2149915Z dotty.tools.dotc.core.Types$Type.normalized(Types.scala:1399)
2021-09-27T15:18:45.2152241Z dotty.tools.dotc.core.Types$AppliedType.superType(Types.scala:4116)
2021-09-27T15:18:45.2155390Z dotty.tools.dotc.core.TypeComparer.provablyDisjoint(TypeComparer.scala:2651)
2021-09-27T15:18:45.2159180Z dotty.tools.dotc.core.TypeComparer.provablyDisjoint(TypeComparer.scala:2647)
2021-09-27T15:18:45.2163003Z dotty.tools.dotc.core.TypeComparer.provablyDisjoint(TypeComparer.scala:2647)
2021-09-27T15:18:45.2166880Z dotty.tools.dotc.core.TrackingTypeComparer.matchCase$1(TypeComparer.scala:2913)
2021-09-27T15:18:45.2170683Z dotty.tools.dotc.core.TrackingTypeComparer.recur$1(TypeComparer.scala:2923)
2021-09-27T15:18:45.2174196Z dotty.tools.dotc.core.TrackingTypeComparer.op$proxy68$1(TypeComparer.scala:2953)
2021-09-27T15:18:45.2178003Z dotty.tools.dotc.core.TrackingTypeComparer.matchCases(TypeComparer.scala:2954)
2021-09-27T15:18:45.2181327Z dotty.tools.dotc.core.Types$MatchType.liftedTree1$2(Types.scala:4711)
2021-09-27T15:18:45.2183711Z dotty.tools.dotc.core.Types$MatchType.matchCases$1(Types.scala:4716)
2021-09-27T15:18:45.2186031Z dotty.tools.dotc.core.Types$MatchType.reduced$$anonfun$1(Types.scala:4720)
2021-09-27T15:18:45.2188902Z dotty.tools.dotc.core.TypeComparer.inSubComparer(TypeComparer.scala:2663)
2021-09-27T15:18:45.2191882Z dotty.tools.dotc.core.TypeComparer.tracked(TypeComparer.scala:2673)
2021-09-27T15:18:45.2194697Z dotty.tools.dotc.core.TypeComparer$.tracked(TypeComparer.scala:2826)
2021-09-27T15:18:45.2197126Z dotty.tools.dotc.core.Types$MatchType.reduced(Types.scala:4720)
2021-09-27T15:18:45.2199491Z dotty.tools.dotc.core.Types$MatchType.tryNormalize(Types.scala:4669)
2021-09-27T15:18:45.2201812Z dotty.tools.dotc.core.Types$Type.normalized(Types.scala:1399)

@OlivierBlanvillain could you have a look?

@smarter
Copy link
Member

smarter commented Sep 28, 2021

The same thing happened on master and that test was simply deleted (at least for now), you can do the same here.

@dwijnand dwijnand merged commit 71acf8d into scala:release-3.1.0 Sep 29, 2021
@dwijnand dwijnand deleted the backport-10867 branch September 29, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants