Parse splices inside quoted patterns as patterns #14277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampauls
changed the title
|
I can't figure out how to rerun the community build, but I'm pretty sure it's just a flaky download error and not a real problem. This is ready for review. |
adampauls
force-pushed
the
splice_pattern
branch
from
2a216a2
to
9ae3b87
Compare
|
(I rebased and the build problem seems to have resolved itself). |
nicolasstucki
approved these changes
Jan 20, 2022
|
Thank you @adampauls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick attempt at addressing the issue mentioned here. To summarize, right now, IIUC the parser treats the splice in
case '{ foo(${ ...}) }no differently than a splice anywhere, meaning it can contain an arbitrary block, even though the typer will treat it as a pattern. This is relatively harmless, since the compiler will reject non-patterns, but it means that some syntax available in patterns is not permitted, likecase '{ foo(${x@MyCustomUnapply(_)}) }. We would like to use binds within splices in case matches, which is why I noticed this problem.I thought I'd put this up here for discussion. Please let me know if I'm misunderstanding how this is all supposed to work.