-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework ElimByName #14295
Merged
Merged
Rework ElimByName #14295
Commits on Jan 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c3b37fd - Browse repository at this point
Copy the full SHA c3b37fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5deb2de - Browse repository at this point
Copy the full SHA 5deb2deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a328dd - Browse repository at this point
Copy the full SHA 5a328ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81cbe32 - Browse repository at this point
Copy the full SHA 81cbe32View commit details -
Install the new ElimByName in place of ByNameClosures
... and drop the old ElimByName.
Configuration menu - View commit details
-
Copy full SHA for bf937ed - Browse repository at this point
Copy the full SHA bf937edView commit details -
I tried to extend specialization to all context functions, not just ones of 0 arity. But that runs into problems for dependent context functions, since the necessary casts get complicated. Since context functions over primitive types are an anti-pattern anyway I don't think we need to optimize this case, after all.
Configuration menu - View commit details
-
Copy full SHA for 3dc3af2 - Browse repository at this point
Copy the full SHA 3dc3af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f208079 - Browse repository at this point
Copy the full SHA f208079View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59734f5 - Browse repository at this point
Copy the full SHA 59734f5View commit details -
- Split out forward reference checks and cross version (i.e. experimental/deprecated) checks into their own miniphases. These have nothing to do with the core tasks of RefChecks. - Move RefChecks earlier in the pipeline, so that it is not affected by ElimByName's questionable type manipulations.
Configuration menu - View commit details
-
Copy full SHA for 368cca1 - Browse repository at this point
Copy the full SHA 368cca1View commit details
Commits on Jan 21, 2022
-
Fix "have same type after erasure" check
Perform the overriding checks after elimByName. I observed some problem with catsEffect2, where a super accessor method with a `() ?=> T` parameter was compared with a corresponding super accessor method with a `=> T` parameter. One of these methods was generated before elimByName, the other after. So comparing them at phase elimRepeated + 1 gave two different types. The problem is fixed by comparing after elimByName, which means that the type of the second method is converted to match the first.
Configuration menu - View commit details
-
Copy full SHA for a9ad052 - Browse repository at this point
Copy the full SHA a9ad052View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.