Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve override detection in CheckUnused, fixes #16865 #16965

Merged

Conversation

PaulCoral
Copy link
Contributor

@szymon-rd, fixes #16865

  • CheckUnused detects override from base type in addition of override flag
  • Update test suit

- CheckUnused detects override from base type in addition of `override` flag
- Update test suit
@szymon-rd szymon-rd merged commit b289cd1 into scala:main Feb 19, 2023
@Kordyjan Kordyjan added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Apr 14, 2023
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Apr 17, 2023
@PaulCoral PaulCoral deleted the fix/wunused/improve_overrride_detection branch June 8, 2023 19:49
@Kordyjan Kordyjan modified the milestones: 3.3.1, 3.3.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Wunused gives false positives on unused explicit parameters of (non-explicitly declared) overridden methods
3 participants